Review main Merged

84497[TASK] Clarify constants do not work in constant conditions

Christian Kuhn CR +2 V +2 Easy +29 −1 updated 06/05/24, 10:21

Commit message

Frontend TypoScript 'constants' do support conditions. But
constants can not be used within conditions, just like
constants in general can not be used within constants.

The patch adapts the "new TS parser" ReST to clarify.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Christian Kuhn uploaded patch set 1 06/05/24, 08:53

  2. core-ci voted on patch set 1 V +1 06/05/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58731

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 06/05/24, 09:03

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 06/05/24, 09:05

    Maybe "[DOCS]"? Then we might also easier catch this to check the documentation for an update on this
  5. Oliver Klee voted on patch set 1 CR +1 V +1 06/05/24, 09:42

  6. Christian Kuhn commented on patch set 1 06/05/24, 09:49

    Reply

    i don't care much - we have various patches doing such thing as [task] ... since we have so many votes already, i tend to merge.
  7. Christian Kuhn voted on patch set 1 CR +2 V +2 06/05/24, 10:20

  8. Christian Kuhn merged patch set 2 06/05/24, 10:21