84506[TASK] Require array in setFlatConstants()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Classes/TypoScript/AST/AstBuilder.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeAstBuilderVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeCommentAwareAstBuilderVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Token/ConstantAwareTokenStream.php+1 −1
Review log 811
-
Christian Kuhn uploaded patch set 1 06/05/24, 14:57
-
core-ci voted on patch set 1 V +1 06/05/24, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58755
-
Christian Kuhn updated the commit message in patch set 2
V +106/05/24, 15:06 -
Christian Kuhn updated the commit message in patch set 3 06/05/24, 15:07
-
Garvin Hicking voted on patch set 3 CR +1 V +1 06/05/24, 15:12
-
core-ci voted on patch set 2 V +1 06/05/24, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58756
-
core-ci voted on patch set 3 V +1 06/05/24, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58757
-
Christian Kuhn commented on patch set 3 06/05/24, 15:18
Note: i know it would be better to have some dedicated toString(array $withConstants) method and to not rely on magic __toString() to avoid the state change altogether, instead. This is more work, though. -
Stefan Bürk voted on patch set 3 CR +1 V +1 06/05/24, 15:27
-
Christian Kuhn voted on patch set 3 CR +2 V +2 06/05/24, 15:33
-
Christian Kuhn merged patch set 4 06/05/24, 15:33