Review 12.4 Merged

84507[TASK] Require array in setFlatConstants()

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 06/05/24, 15:33

Commit message

Constant substitution in TS parser is implemented in
ConstantAwareTokenStream. It kicks in by casting the
stream to string after existing constants have been
set using ConstantAwareTokenStream->setFlatConstants().

To not have a "polluted" stream after setFlatConstants(),
the constants are reset using setFlatConstants(null)
after use. Ugly. Patch #102742 established a partial
solution already by cloning the stream instead.

Finish the clone approach to disallow setFlatConstants(null).
Add two missing void return annotations at related places
along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 3

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/05/24, 15:07

  2. core-ci voted on patch set 1 V +1 06/05/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58758

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 06/05/24, 15:33

  4. Christian Kuhn merged patch set 2 06/05/24, 15:33