Review main Merged

84511[TASK] Make TS [END] an own include object

Christian Kuhn CR +2 V +2 Normal +197 −9 updated 06/07/24, 00:30

Commit message

The new v12 TypoScript parser works pretty well. It is time
to rule out some of its rough edges in v13: In hinsight,
the biggest structural issues of the rewrite reside in the
IncludeTree structure, which has been oversimplified at some
places.

One problem is reflected within the BE modules 'TypoScript ->
Included TypoScript' and 'Page TSconfig -> Include page TSconfig',
which are not as easy to grasp as they could be. Those are
essentially a straight view of the created IncludeTree.

The patch changes a single decision within these trees:
"condition end" token ("[END]" / "[GLOBAL]") have been added
to the line stream of the currently given tree object until
now, but they should be a dedicated node reflected in the tree.

The patch turns "condition stop" into dedicated objects within
the tree. This makes BE include tree display more easy to grasp
and allows simplified scanning for missing and superfluous condition
stop lines in the future. It is also a base for better rendering
of the "code view" within the modules.

Additionally, condition and condition-else now render their
condition tokens in the BE modules, which should help
integrators to understand the tree more easily by simplified
matching to known parts of TS source.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 1321

  1. Christian Kuhn uploaded patch set 1 06/06/24, 12:13

  2. core-ci voted on patch set 1 V +1 06/06/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58796

  3. Christian Kuhn updated the commit message in patch set 2 V +1 06/06/24, 15:22

  4. core-ci voted on patch set 2 V +1 06/06/24, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58812

  5. Christian Kuhn uploaded patch set 3 V +1 06/06/24, 15:44

  6. core-ci voted on patch set 3 V +1 06/06/24, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58814

  7. Christian Kuhn uploaded patch set 4 V +1 06/06/24, 16:41

  8. Christian Kuhn uploaded patch set 5 06/06/24, 16:42

  9. Christian Kuhn updated the commit message in patch set 6 06/06/24, 16:47

  10. core-ci voted on patch set 4 V -1 06/06/24, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58818

  11. core-ci voted on patch set 5 V +1 06/06/24, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58819

  12. core-ci voted on patch set 6 V +1 06/06/24, 16:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58820

  13. Christian Kuhn updated the commit message in patch set 7 V +1 06/06/24, 16:54

  14. Christian Kuhn updated the commit message in patch set 8 06/06/24, 16:57

  15. core-ci voted on patch set 7 V +1 06/06/24, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58821

  16. core-ci voted on patch set 8 V +1 06/06/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58822

  17. Jasmina Ließmann voted on patch set 8 CR +1 V +1 06/06/24, 18:02

  18. Stefan Bürk commented on patch set 8 CR -1 06/06/24, 19:57

    reviewing ....
  19. Stefan Bürk voted on patch set 8 CR +1 V +1 06/06/24, 20:11

  20. Georg Ringer voted on patch set 8 CR +2 V +2 06/07/24, 00:30

  21. Georg Ringer merged patch set 9 06/07/24, 00:30