84542[TASK] Add ARIA role and labelledby to content elements in page module
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- morgane garcia +1
- Christian Kuhn +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- morgane garcia +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1621
-
Christian Rath-Ulrich uploaded patch set 1 06/10/24, 12:30
-
core-ci voted on patch set 1 V +1 06/10/24, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59006
-
Mathias Brodala updated the commit message in patch set 2
V +106/10/24, 12:47 -
Mathias Brodala commented on patch set 2 06/10/24, 12:48
No need to write down what Git already tells us. ;-) -
core-ci voted on patch set 2 V +1 06/10/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59009
-
morgane garcia voted on patch set 2 CR +1 V +1 06/10/24, 14:07
-
Jasmina Ließmann commented on patch set 2 06/10/24, 14:29
Record.html:2"-lable" - I think it's a typo. Please use 'label'.Record.html:3I prefer using: `id={item.record.uid} - <f:if condition="{item.record.header}">[{item.record.header}] </f:if>{item.record.CType}` - so no double whitespace is set if the if condition isn't matching. -
Jasmina Ließmann uploaded patch set 3
CR +1V +106/10/24, 14:32 -
Jasmina Ließmann commented on patch set 3 06/10/24, 14:32
Record.html:2ReplyDoneRecord.html:3ReplyDone -
core-ci voted on patch set 3 V +1 06/10/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59017
-
Jasmina Ließmann commented on patch set 3 06/10/24, 14:42
Record.html:3{item.record.CType} currently only returns the CType value, but not the speaking label as in icon title tag. -
Jasmina Ließmann uploaded patch set 4
V +106/10/24, 14:51 -
Jasmina Ließmann commented on patch set 4 06/10/24, 14:51
Record.html:3ReplyDone -
core-ci voted on patch set 4 V +1 06/10/24, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59020
-
Jasmina Ließmann updated the commit message in patch set 5
V +106/10/24, 15:16 -
Jasmina Ließmann voted on patch set 5 CR +1 V +1 06/10/24, 15:16
-
core-ci voted on patch set 5 V +1 06/10/24, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59031
-
morgane garcia voted on patch set 5 CR +1 V +1 06/10/24, 15:36
-
Christian Kuhn voted on patch set 5 CR +1 V +1 06/10/24, 15:41
-
Jasmina Ließmann voted on patch set 5 CR +2 V +2 06/10/24, 15:43
-
Jasmina Ließmann merged patch set 6 06/10/24, 15:43