Review main Merged

84542[TASK] Add ARIA role and labelledby to content elements in page module

Christian Rath-Ulrich CR +2 V +2 Easy +11 −1 updated 06/10/24, 15:43

Commit message

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • morgane garcia +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • morgane garcia +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1621

  1. Christian Rath-Ulrich uploaded patch set 1 06/10/24, 12:30

  2. core-ci voted on patch set 1 V +1 06/10/24, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59006

  3. Mathias Brodala updated the commit message in patch set 2 V +1 06/10/24, 12:47

  4. Mathias Brodala commented on patch set 2 06/10/24, 12:48

    No need to write down what Git already tells us. ;-)
  5. core-ci voted on patch set 2 V +1 06/10/24, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59009

  6. morgane garcia voted on patch set 2 CR +1 V +1 06/10/24, 14:07

  7. Jasmina Ließmann commented on patch set 2 06/10/24, 14:29

    Record.html:2

    "-lable" - I think it's a typo. Please use 'label'.

    Record.html:3

    I prefer using: `id={item.record.uid} - <f:if condition="{item.record.header}">[{item.record.header}] </f:if>{item.record.CType}` - so no double whitespace is set if the if condition isn't matching.
  8. Jasmina Ließmann uploaded patch set 3 CR +1 V +1 06/10/24, 14:32

  9. Jasmina Ließmann commented on patch set 3 06/10/24, 14:32

    Record.html:2 Reply

    Done

    Record.html:3 Reply

    Done
  10. core-ci voted on patch set 3 V +1 06/10/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59017

  11. Jasmina Ließmann commented on patch set 3 06/10/24, 14:42

    Record.html:3

    {item.record.CType} currently only returns the CType value, but not the speaking label as in icon title tag.
  12. Jasmina Ließmann uploaded patch set 4 V +1 06/10/24, 14:51

  13. Jasmina Ließmann commented on patch set 4 06/10/24, 14:51

    Record.html:3 Reply

    Done
  14. core-ci voted on patch set 4 V +1 06/10/24, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59020

  15. Jasmina Ließmann updated the commit message in patch set 5 V +1 06/10/24, 15:16

  16. Jasmina Ließmann voted on patch set 5 CR +1 V +1 06/10/24, 15:16

  17. core-ci voted on patch set 5 V +1 06/10/24, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59031

  18. morgane garcia voted on patch set 5 CR +1 V +1 06/10/24, 15:36

  19. Christian Kuhn voted on patch set 5 CR +1 V +1 06/10/24, 15:41

  20. Jasmina Ließmann voted on patch set 5 CR +2 V +2 06/10/24, 15:43

  21. Jasmina Ließmann merged patch set 6 06/10/24, 15:43