84549[TASK] Update label of button to create content in page module
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Christian Kuhn +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Christian Kuhn +1
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1925
-
Christian Rath-Ulrich uploaded patch set 1 06/10/24, 16:13
-
core-ci voted on patch set 1 V +1 06/10/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59051
-
morgane garcia commented on patch set 1 06/10/24, 16:36
-
Christian Rath-Ulrich uploaded patch set 2
V +106/10/24, 17:08 -
Christian Rath-Ulrich commented on patch set 2 06/10/24, 17:11
locallang_layout.xlf:97ReplyAfter a short discussion with Jasmina Ließmann its insert now -
core-ci voted on patch set 2 V +1 06/10/24, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59059
-
morgane garcia commented on patch set 2 06/10/24, 17:21
locallang_layout.xlf:97Just correct the orthography of word "Element" and it will be OK -
Christian Rath-Ulrich uploaded patch set 3
V +106/10/24, 17:44 -
morgane garcia voted on patch set 3 CR +1 V +1 06/10/24, 17:50
-
core-ci voted on patch set 3 V +1 06/10/24, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59062
-
Jasmina Ließmann commented on patch set 3 06/10/24, 18:56
locallang_layout.xlf:97ReplyDone -
Jasmina Ließmann commented on patch set 3 V +1 06/11/24, 18:31
Looks good. I'm unsure if the language key is used somewhere else and now the title could be misleading. -
Michael Telgkamp commented on patch set 3 V -1 06/12/24, 13:59
As we try to unify the wording, it would be good to use "Create new content" as label. We already use "Create new record" on the list page and "`Create new` wizzard" in the extended context menu of a page. As mentioned in the other comment it would be good to have a more informative translation key, e.g. `createNewContent`.locallang_layout.xlf:96The content identifier is not clear enaugh, it should be modified. -
Christian Rath-Ulrich uploaded patch set 4
CR +1V +106/13/24, 07:11 -
core-ci voted on patch set 4 V +1 06/13/24, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59405
-
Jasmina Ließmann commented on patch set 4 06/13/24, 07:19
locallang_layout.xlf:96ReplyDone -
Jasmina Ließmann uploaded patch set 5
V +106/13/24, 07:32 -
Jasmina Ließmann uploaded patch set 6 06/13/24, 07:38
-
Michael Telgkamp voted on patch set 6 CR +1 V +1 06/13/24, 07:39
-
Jasmina Ließmann voted on patch set 6 CR +1 V +1 06/13/24, 07:46
-
core-ci voted on patch set 5 V -1 06/13/24, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59415
-
core-ci voted on patch set 6 V +1 06/13/24, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59416
-
Christian Kuhn voted on patch set 6 CR +1 V +1 06/13/24, 08:00
-
Jasmina Ließmann voted on patch set 6 CR +2 V +2 06/13/24, 08:01
-
Jasmina Ließmann merged patch set 7 06/13/24, 08:12
locallang_layout.xlf:97