Review main Merged

84616[TASK] Update bookmark related link titles

Jasmina Ließmann CR +2 V +2 Normal +26 −26 updated 06/13/24, 08:01

Commit message

The TYPO3 backend has a bookmark function with which records can be
saved as bookmarks. Since any other record type can be saved in
addition to pages, the corresponding link titles are now adjusted.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1013

  1. Jasmina Ließmann uploaded patch set 1 06/11/24, 12:49

  2. Mathias Brodala commented on patch set 1 06/11/24, 12:51

    Please make sure to describe what you did to fix the issue, not the issue itself. See https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#summary-line-first-line
  3. core-ci voted on patch set 1 V -1 06/11/24, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59188

  4. Jasmina Ließmann commented on patch set 1 06/11/24, 12:58

    Reply

    Thank you, but this was only a first draft (WIP). Hence the spontaneous, short commit title.
  5. Mathias Brodala commented on patch set 1 06/11/24, 12:59

    Reply

    Totally get that, no worries. :-)
  6. Jasmina Ließmann updated the commit message in patch set 2 V -1 06/11/24, 19:30

  7. core-ci voted on patch set 2 V -1 06/11/24, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59244

  8. Jasmina Ließmann uploaded patch set 3 V -1 06/12/24, 08:57

  9. core-ci voted on patch set 3 V +1 06/12/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59291

  10. Christian Kuhn voted on patch set 3 CR +1 V +1 06/13/24, 07:21

  11. Michael Telgkamp voted on patch set 3 CR +1 V +1 06/13/24, 07:26

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 06/13/24, 07:43

  13. Christian Kuhn merged patch set 4 06/13/24, 08:01