84695[FEATURE] Allow editing metadata of multiple files in "columns only" mode
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/filelist/file-list.ts+7 −1
- typo3/sysext/core/Documentation/Changelog/13.2/Feature-104095-EditSpecificColumnsOfMultipleFilesInFilelistModule.rst1new+35 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+14 −0
- typo3/sysext/filelist/Resources/Private/Language/locallang_mod_file_list.xlf2+3 −0
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+14 −5
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
Review log 1114
-
Oli Bartsch uploaded patch set 1 06/13/24, 13:07
-
core-ci voted on patch set 1 V +1 06/13/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59488
-
Garvin Hicking uploaded patch set 2
V +106/13/24, 13:57RST -
Garvin Hicking commented on patch set 2 CR +1 V +1 06/13/24, 14:02
Works pretty well. Just one minor thought about the button label, non-blocking.locallang_mod_file_list.xlf:19When seing "Edit Metadata" next to "Edit selected columns" I wonder if everyone directly understands the difference between "selected" (multiple files selected) and "selected columns" (selected columns of also selecteed files). How about: "Edit all metadata" "Edit column-specific metadata" (Yes, I think this proposal is too long. Not "blocking" this of course if everyone else thinks this is a non-issue) -
core-ci voted on patch set 2 V +1 06/13/24, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59501
-
Oli Bartsch uploaded patch set 3
CR +1V +106/14/24, 12:51 -
Oli Bartsch commented on patch set 3 06/14/24, 12:53
locallang_mod_file_list.xlf:19ReplyRephrased it to make it ,more clear. Actually the label is now even shorter. -
core-ci voted on patch set 3 V +1 06/14/24, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59602
-
Garvin Hicking voted on patch set 3 CR +1 V +1 06/14/24, 13:09
-
Christian Kuhn voted on patch set 3 CR +1 V +1 06/14/24, 13:17
-
Jochen Roth voted on patch set 3 CR +1 V +1 06/14/24, 13:39
-
Oli Bartsch voted on patch set 3 CR +2 V +2 06/14/24, 16:04
-
Oli Bartsch merged patch set 4 06/14/24, 16:04
-
Simon Schaufelberger commented on patch set 4 06/14/24, 17:08
Feature-104095-EditSpecificColumnsOfMultipleFilesInFilelistModule.rst:14Unresolvedthe only once