Review main Merged

84725[BUGFIX] Allow CType menu_categorized in strict mode

Georg Ringer CR +2 V +2 Easy +1 −2 updated 02/26/26, 11:18

Commit message

When running MySQL / MariaDB with "ONLY_FULL_GROUP_BY"
mode, the menu_categorized now does not use a group by
anymore, but instead uses DISTINCT, which is also working
across all supported DBMS.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Georg Ringer uploaded patch set 1 06/15/24, 19:26

  2. Georg Ringer commented on patch set 1 06/15/24, 19:27

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 06/15/24, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59650

  4. Georg Ringer rebased onto patch set 2 V -1 07/08/24, 17:24

  5. core-ci voted on patch set 2 V -1 07/08/24, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61184

  6. Benni Mack commented on patch set 2 07/09/24, 06:06

    if we use count, then overlays (language + workspace) won't work anymore, resulting in the same issues we have in Extbase. I guess we need to document that then
  7. Georg Ringer abandoned the change 07/28/24, 06:47

  8. Georg Ringer restored the change 02/25/26, 11:20

  9. Georg Ringer uploaded patch set 3 V -1 02/25/26, 11:21

  10. core-ci voted on patch set 3 V +1 02/25/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96813

  11. Benni Mack voted on patch set 3 CR +1 V +1 02/25/26, 11:36

  12. Garvin Hicking commented on patch set 3 CR -1 02/26/26, 08:29

    Hang on, I'm running the two queries on all of our supported DB engines just to be safe
  13. Garvin Hicking commented on patch set 3 CR +2 V +2 02/26/26, 11:10

    Tested this and works on: mysql 5.7, 8.0, 8.1 mariadb 10.2, 10.3, 10.4, 10.5, 10.6, 10.7, 10.8, 10.9, 10.10, 10.11, 11.0, 11.1 postgres 11, 12, 13, 14, 15, 16 sqlite Tested with my docker-queryrunner tool if anyone cares: https://github.com/garvinhicking/docker-queryrunner
  14. Garvin Hicking commented on patch set 3 02/26/26, 11:10

    Reply

    Done
  15. Garvin Hicking merged patch set 4 02/26/26, 11:18