84750[WIP][BUGFIX|TASK|FEATURE] Implement keyboard navigation for result pagination
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 56
-
Ayke Halder uploaded patch set 1 06/18/24, 09:24
-
core-ci voted on patch set 1 V +1 06/18/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59787
-
Michael Telgkamp commented on patch set 1 CR -1 06/18/24, 14:00
I would prefer to have real buttons inside the web component element to have the default browser interaction pattern in place, otherwise the keyboard interaction probably needs to be implemented, because a role is a promise and no automatic interaction model is added by the browser by adding the role.result-pagination.ts:49There is no attribute `aria-role` it needs to be `role` only - or the interactive element should be a `<button type="button>` inside the web component to have the role button together with the default browser behaviour.result-pagination.ts:69There is no attribute `aria-role` it needs to be `role` only. (see above)result-pagination.ts:87There is no attribute `aria-role` it needs to be `role` only. (see above) -
Ayke Halder commented on patch set 1 06/18/24, 17:52
This change is ready for review.Reply
I'd like to have real buttons here, too. If we add real buttons, will this still be mergeable into TYPO3 12.4?result-pagination.ts:49ReplyDoneresult-pagination.ts:69ReplyDoneresult-pagination.ts:87ReplyDone -
Ayke Halder abandoned the change 06/18/24, 17:53
Sorry opened another PR here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84782 -
Ayke Halder commented on patch set 1 06/19/24, 05:32
Reply