84789[TASK] Rename twitter to x in labels
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jasmina Ließmann +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1518
-
Georg Ringer uploaded patch set 1 06/19/24, 20:44
-
Georg Ringer commented on patch set 1 06/19/24, 20:44
This change is ready for review. -
core-ci voted on patch set 1 V +1 06/19/24, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59870
-
Garvin Hicking commented on patch set 1 06/19/24, 20:57
Sorry I can't vote on this in good conscience. This "X" just looks stupid. -
Benni Mack commented on patch set 1 06/19/24, 21:07
I suggest we just name it "X / Twitter" in all labels? -
Garvin Hicking commented on patch set 1 06/19/24, 21:36
Reply
That would work for me. I would keep current DB field names to not create code migration issues. -
Georg Ringer uploaded patch set 2
V +106/19/24, 21:59 -
core-ci voted on patch set 2 V +1 06/19/24, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59879
-
Garvin Hicking commented on patch set 2 CR +1 V +1 06/19/24, 22:30
X marks the sloth -
Simon Schaufelberger voted on patch set 2 CR +1 V +1 06/19/24, 23:04
-
Jasmina Ließmann commented on patch set 2 06/20/24, 12:03
Index.rst:178Should this be labelled as "X / Twitter Cards" instead of "X Cards" only? Just to use the same wording as in other places. -
Christian Kuhn commented on patch set 2 06/20/24, 12:54
Index.rst:178ReplyDone -
Christian Kuhn uploaded patch set 3
CR +1V +106/20/24, 12:54 -
Christian Kuhn voted on patch set 3 CR +1 V +1 06/20/24, 12:54
-
Jasmina Ließmann voted on patch set 3 CR +1 V +1 06/20/24, 12:54
-
Christian Kuhn voted on patch set 3 CR +2 V +2 06/20/24, 12:55
-
core-ci voted on patch set 3 V +1 06/20/24, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59914
-
Christian Kuhn merged patch set 4 06/20/24, 13:06