Review main Merged

84811[TASK] Clarify description of [SYS][ipAnonymization]

Georg Ringer CR +2 V +2 Easy +1 −1 updated 06/21/24, 07:53

Commit message

The IP anonymization task uses its own configuration and doesn't allow a
fallback to the configuration defined in the settings. Therefore the
misleading text is removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 06/20/24, 21:23

  2. Georg Ringer commented on patch set 1 06/20/24, 21:24

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/20/24, 21:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59948

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 06/21/24, 04:55

    Do I read that right - the ipAnonizationUtility is the only place the config value is respected, and that utility in turn is solely utilized by the CSP Middleware and nothing else of the core?
  5. Benni Mack commented on patch set 1 CR +1 V +1 06/21/24, 06:21

    Reply

    Nope. it's in the IpAnonymalizatinoTask as well (that's where the Utility is also used)
  6. Benni Mack voted on patch set 1 CR +2 V +2 06/21/24, 07:53

  7. Benni Mack merged patch set 2 06/21/24, 07:53