Review main Merged

84814[TASK] Clean up parseFunc functionality in ContentObjectRenderer

Benni Mack CR +2 V +2 Normal +57 −65 updated 06/21/24, 09:09

Commit message

This change
* simplifies allowTags and denyTags in lib.parseFunc
  by comparing with in_array rather than "inList()"
  for EVERY tag!
* Remove superfluous if() statements
  - GeneralUtility::get_tag_attributes always returns an array
  - substr does not return "false" but an empty string since PHP 8.0

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack uploaded patch set 1 06/21/24, 07:11

  2. core-ci voted on patch set 1 V +1 06/21/24, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59974

  3. Benni Mack updated the commit message in patch set 2 V +1 06/21/24, 07:53

  4. core-ci voted on patch set 2 V +1 06/21/24, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/59981

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 06/21/24, 09:08

  6. Georg Ringer voted on patch set 2 CR +2 V +2 06/21/24, 09:09

  7. Georg Ringer merged patch set 3 06/21/24, 09:09