Review main Merged

84854[BUGFIX] Respect prev sections for cropping

Stefan Froemken CR +2 V +2 Hard +242 −127 updated 04/02/25, 22:11

Commit message

While searching for next space in current
text section of HtmlCropper it now respects
previous processed text sections to prevent
cutting into first word of further sections.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1724

  1. Stefan Froemken uploaded patch set 1 06/21/24, 23:03

  2. core-ci voted on patch set 1 V +1 06/21/24, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60040

  3. Georg Ringer updated the commit message in patch set 2 V +1 06/22/24, 03:42

  4. Georg Ringer voted on patch set 2 CR +1 V +1 06/22/24, 03:42

  5. core-ci voted on patch set 2 V +1 06/22/24, 03:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60044

  6. Markus Klein commented on patch set 2 06/22/24, 11:06

    Is there any change in the moved code? General thing: parsing HTML with regex is, well, error-prone. We should really use a real HTML parser here instead.
  7. Stefan Froemken commented on patch set 2 06/22/24, 12:13

    Reply

    I had enormous problems with all these variablenames. Where are they used, overwritten, so, I have cut this method just into peaces and give nearly every variable new and easy to remember names. But code structure ist still the same. I love to see ONE method on my monitor without scrolling, that makes reading much better. At that point I have checked, that all original TYPO3 Core Tests are still running. Please keep an eye on the first 28 lines of "cropSectionToNextSpace". There you will see my modification where the previous text sections are added temporary in front or back of the exploded current text section and afterwards I remove it again with array_diff.
  8. Markus Klein commented on patch set 2 06/22/24, 17:59

    Reply

    Thanks for the explanation
  9. Markus Klein commented on patch set 2 08/18/24, 18:43

    pls rebase this patch
  10. Stefan Froemken uploaded patch set 3 CR +1 V +1 08/19/24, 06:20

  11. core-ci voted on patch set 3 V +1 08/19/24, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63748

  12. Benni Mack updated the commit message in patch set 4 V +1 10/18/24, 13:43

  13. Benni Mack rebased onto patch set 5 10/21/24, 06:59

  14. core-ci voted on patch set 5 V +1 10/21/24, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68281

  15. Benni Mack rebased onto patch set 6 V +1 03/11/25, 10:36

  16. core-ci voted on patch set 6 V +1 03/11/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75471

  17. Georg Ringer voted on patch set 6 CR +1 V +1 03/13/25, 20:48

  18. Benni Mack rebased onto patch set 7 CR +1 V +1 04/01/25, 17:12

  19. core-ci voted on patch set 7 V +1 04/01/25, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76807

  20. Markus Klein uploaded patch set 8 V +1 04/02/25, 19:17

  21. Markus Klein voted on patch set 8 CR +1 V +1 04/02/25, 19:17

  22. core-ci voted on patch set 8 V +1 04/02/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76904

  23. Stefan Bürk voted on patch set 8 CR +2 V +2 04/02/25, 21:28

  24. Stefan Bürk merged patch set 9 04/02/25, 22:11