84857[TASK] Avoid implicitly nullable class method parameter in tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 51
- typo3/sysext/core/Tests/Acceptance/Support/Helper/Config.php+3 −3
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Classes/Controller/ContentController.php+1 −1
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/DateTimeTypesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/FixedPointTypesTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/FloatingPointTypesTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ColumnDefinitionAttributesTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ReferenceDefinitionTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixtureMySQLSchemaManager.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixturePostgreSQLSchemaManager.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/SchemaManager/Fixtures/SchemaManager/FixtureSQLiteSchemaManager.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/FailsafeContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php+1 −1
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeValidSpoolFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+2 −2
Show 31 more files
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Security/ContentSecurityPolicy/UriValueTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/IpAnonymizationUtilityTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Domain/Model/Main.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Classes/Domain/Model/Squeeze.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_data_mapper/Classes/Domain/Model/Example.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/type_converter_test/Classes/Property/TypeConverter/AnimalTypeConverter.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/type_converter_test/Classes/Property/TypeConverter/CatTypeConverter.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/type_converter_test/Classes/Property/TypeConverter/CountableTypeConverter.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/type_converter_test/Classes/Property/TypeConverter/ExtendedCountableTypeConverter.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Extension/action_controller_test/Classes/Controller/TestController.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/RepositoryTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Property/PropertyMapperTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Utility/LocalizationUtilityTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/Fixtures/DateTimeSubFixture.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverterRegistryTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+1 −1
- typo3/sysext/felogin/Tests/Unit/Configuration/RecoveryConfigurationTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/SvgImageViewHelperTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/RouteTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkHandlingController.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/TestSet.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariableValue.php+3 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/Subject.php+1 −1
- typo3/sysext/reports/Tests/Unit/Report/Status/StatusTest.php+1 −1
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php+1 −1
Review log 913
-
Stefan Bürk uploaded patch set 1 06/23/24, 03:05
-
core-ci voted on patch set 1 V -1 06/23/24, 03:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60078
-
Stefan Bürk uploaded patch set 2
V -106/23/24, 11:07 -
Stefan Bürk rebased onto patch set 3 06/23/24, 11:11
-
core-ci voted on patch set 2 V +1 06/23/24, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60095
-
core-ci voted on patch set 3 V +1 06/23/24, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60097
-
Stefan Bürk updated the commit message in patch set 4
V +106/23/24, 11:32 -
core-ci voted on patch set 4 V +1 06/23/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60099
-
Oliver Klee voted on patch set 4 V +1 06/23/24, 11:48
-
Oliver Klee voted on patch set 4 CR +1 06/23/24, 11:58
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 06/23/24, 12:20
-
Stefan Bürk voted on patch set 4 CR +2 V +2 06/23/24, 12:55
-
Stefan Bürk merged patch set 5 06/23/24, 12:55