Review main Merged

84871[BUGFIX] Keep file extension if omitting during renaming

Georg Ringer CR +2 V +2 Easy +5 −0 updated 03/11/25, 08:30

Commit message

If a file is renamed in the file list and no file extension is provided,
the original file extension is appended.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1723

  1. Georg Ringer uploaded patch set 1 06/23/24, 19:36

  2. Georg Ringer commented on patch set 1 06/23/24, 19:36

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 06/23/24, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60126

  4. Oliver Klee updated the commit message in patch set 2 V +1 06/23/24, 20:39

  5. core-ci voted on patch set 2 V +1 06/23/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60127

  6. Garvin Hicking commented on patch set 2 V +1 06/23/24, 23:18

    I thought about this one a little longer, as I'm not 100% sure this is bulletproof and could lead to another odd scenario. But this is only a hunch and I cannot back it up with a "breaking idea". I would however prefer to not bake this into v11 for odd side-effects?
  7. Georg Ringer updated the commit message in patch set 3 V +1 06/24/24, 06:26

  8. core-ci voted on patch set 3 V +1 06/24/24, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60152

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 06/24/24, 07:01

  10. Patrick Schriner commented on patch set 3 CR +1 06/24/24, 12:58

    While the code works as described, I think it's counter-intuitive. The dialog displays the filename including extension and if you rename the file that file may not be what it seems. But the dialog implied that you could rename the file as a whole. * Thunar / Linux will "select" the filename part, making the obvious choice (keeping the file extension) the default * Windows (on the explorer / gui level) never displays the file extension, which makes renaming the file (type) a hard task for casual users
  11. Georg Ringer commented on patch set 3 06/24/24, 13:06

    Reply Unresolved

    regular users should never rename the extension at all. except some plaintext formats like txt/sql there is IMHO hardly any extension which can be just changed
  12. Benni Mack commented on patch set 3 06/24/24, 13:41

    Georg, we need to do this not inside ResourceStorage but outside (where it is used, I assume ExtendedFileUtiltity)
  13. Georg Ringer commented on patch set 3 06/25/24, 21:37

    Reply

    ResourceStorage => $this->driver->renameFile => LocalDriver->rename => $result = rename($sourcePath, $targetPath); so we can only fix it in LocalDriver?
  14. Benni Mack updated the commit message in patch set 4 CR +1 V +1 10/18/24, 13:36

  15. core-ci voted on patch set 4 V -1 10/18/24, 22:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67998

  16. Benni Mack rebased onto patch set 5 V -1 02/03/25, 20:03

  17. core-ci voted on patch set 5 V +1 02/03/25, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73445

  18. Benni Mack rebased onto patch set 6 V +1 03/02/25, 14:56

  19. core-ci voted on patch set 6 V +1 03/02/25, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74973

  20. Benni Mack commented on patch set 6 CR +1 V +1 03/08/25, 19:49

    Reply

    double-checked. I'm fine with this change in here.
  21. Garvin Hicking voted on patch set 6 CR +1 V +1 03/08/25, 20:10

  22. Georg Ringer voted on patch set 6 CR +2 V +2 03/11/25, 08:29

  23. Georg Ringer merged patch set 7 03/11/25, 08:30