84872[BUGFIX] Silence regexp pattern errors in EXT:redirects
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1216
-
Stefan Bürk uploaded patch set 1 06/23/24, 21:20
-
core-ci voted on patch set 1 V +1 06/23/24, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60128
-
Stefan Bürk updated the commit message in patch set 2
V +106/23/24, 21:36 -
core-ci voted on patch set 2 V +1 06/23/24, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60133
-
Garvin Hicking updated the commit message in patch set 3
V +106/23/24, 22:01 -
Garvin Hicking commented on patch set 3 CR +1 V +1 06/23/24, 22:04
Minor question, there's another un-silenced preg_match in that file: ``` $matchResult = preg_match($matchedRedirect['source_path'], $uriToCheck, $matches); ``` I suppose that's less likely to fail? Don't know my way around ext:redirects too well. -
core-ci voted on patch set 3 V +1 06/23/24, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60138
-
Stefan Bürk voted on patch set 3 CR -1 06/24/24, 06:55
-
Stefan Bürk uploaded patch set 4
CR +1V +106/24/24, 07:36 -
Stefan Bürk commented on patch set 4 06/24/24, 07:37
Reply
Should have been save, as this only processes redirect records already having a match successfully done. Added the silence operator - better be safe than sorry. -
core-ci voted on patch set 4 V +1 06/24/24, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60159
-
Oliver Klee voted on patch set 4 CR +1 06/24/24, 09:54
-
Garvin Hicking voted on patch set 4 CR +1 V +1 06/24/24, 18:44
-
Benni Mack voted on patch set 4 CR +1 V +1 06/25/24, 05:17
-
Stefan Bürk voted on patch set 4 CR +2 V +2 06/25/24, 08:19
-
Stefan Bürk merged patch set 5 06/25/24, 08:31