Review main Merged

84897[BUGFIX] Fix invalid FormEngine HTML structure on edge-case

Garvin Hicking CR +2 V +2 Easy +4 −4 updated 06/29/24, 13:11

Commit message

When the TCA type "group" or "folder" is rendered in FormEngine,
under certain circumstances the HTML structure would close add
`<div>` elements without opening those first. This will lead
to a record not being editable, because variables are wrongly
transferred due to the browser-rendering of wrong HTML nesting
levels.

This behaviour is an edge case and only happens with this TCA
configuration:

* either `config[hideMoveIcons]` is set to `true`
* or `config[hideDeleteIcon]` is set to `true`

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Markus Klein +1
    • Mogens Fiebrandt +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Markus Klein +1
    • Mogens Fiebrandt +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Garvin Hicking uploaded patch set 1 06/25/24, 10:46

  2. core-ci voted on patch set 1 V +1 06/25/24, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60281

  3. Garvin Hicking uploaded patch set 2 V +1 06/25/24, 10:55

    Rearranged for non empty element
  4. core-ci voted on patch set 2 V +1 06/25/24, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60282

  5. Georg Ringer voted on patch set 2 CR +1 V +1 06/25/24, 12:04

  6. Markus Klein voted on patch set 2 CR +1 V +1 06/25/24, 13:46

  7. Mogens Fiebrandt voted on patch set 2 CR +1 06/29/24, 09:42

  8. Mogens Fiebrandt voted on patch set 2 V +1 06/29/24, 10:17

  9. Stefan Bürk voted on patch set 2 CR +2 V +2 06/29/24, 13:00

  10. Stefan Bürk merged patch set 3 06/29/24, 13:11