84912[BUGFIX] Fix ext_config_template.txt zero-based category ordering
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 912
-
Garvin Hicking uploaded patch set 1 06/25/24, 14:31
-
core-ci voted on patch set 1 V +1 06/25/24, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60310
-
Stefan Bürk commented on patch set 1 06/25/24, 15:13
-
Garvin Hicking uploaded patch set 2
V +106/28/24, 22:27 -
Garvin Hicking commented on patch set 2 06/28/24, 22:29
AstConstantCommentVisitor.php:405ReplyI actually had it like that initially and then felt I might be missing something here and changed it to strlen(). With your suggestion in mind I now feel better to do it like that. :-) -
core-ci voted on patch set 2 V +1 06/28/24, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60604
-
Christian Kuhn updated the commit message in patch set 3
V +106/28/24, 23:04 -
core-ci voted on patch set 3 V +1 06/28/24, 23:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60605
-
Christian Kuhn commented on patch set 3 CR +1 V +1 06/29/24, 14:49
thank you! -
Stefan Bürk voted on patch set 3 CR +1 V +1 06/30/24, 11:43
-
Christian Kuhn voted on patch set 3 CR +2 V +2 06/30/24, 12:04
-
Christian Kuhn merged patch set 4 06/30/24, 12:16
AstConstantCommentVisitor.php:405