Review main Merged

84926[TASK] Disable failing unit-case test data set

Stefan Bürk CR +2 V +2 Easy +5 −3 updated 06/26/24, 12:16

Commit message

Since recently upgraded PHP-version the
10mb big xml unit test failes.

The `\LIBXML_PARSEHUGE` xml option could
be used to mitigate this case but would
not explain the change from PHP yet.

Thus the decision has been made to disable
the failing data set as a temporary solution
to avoid disturbance for core contribution
until this issue has been investigated and
reported to PHP itself.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Markus Hofmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Markus Hofmann +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 06/26/24, 11:35

  2. Stefan Bürk commented on patch set 2 06/26/24, 11:39

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 06/26/24, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60375

  4. core-ci voted on patch set 2 V +1 06/26/24, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60376

  5. Benni Mack voted on patch set 2 CR +1 V +1 06/26/24, 12:11

  6. Markus Hofmann voted on patch set 2 CR +1 V +1 06/26/24, 12:16

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 06/26/24, 12:16

  8. Stefan Bürk merged patch set 3 06/26/24, 12:16

  9. Jochen Roth voted on patch set 2 CR +1 V +1 06/26/24, 12:16