84944[BUGFIX] Check array access in FilesControlContainer
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1114
-
Georg Ringer uploaded patch set 1 06/27/24, 14:14
-
Georg Ringer commented on patch set 1 06/27/24, 14:14
This change is ready for review. -
core-ci voted on patch set 1 V +1 06/27/24, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60466
-
Garvin Hicking updated the commit message in patch set 2
V +106/27/24, 14:47 -
core-ci voted on patch set 2 V +1 06/27/24, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60468
-
Christian Kuhn voted on patch set 2 CR +1 06/27/24, 21:01
-
Oliver Klee voted on patch set 2 CR +1 06/28/24, 07:25
-
Oli Bartsch commented on patch set 2 V -1 06/28/24, 08:07
Not sure if this is the correct solution. By initializing min/max here, the "Add image" button is rendered and when such user tries to add an image, an error occurs: "No table modify permission for user 14 on table sys_file_reference". We might just want to fix this in the container, where the array access happens. -
Stefan Bürk commented on patch set 2 06/28/24, 09:22
Reply
Had the same question in mind after quick look last night. This should be fixed in container instead, I guess - but did not checked further on that. -
Georg Ringer uploaded patch set 3
CR +1V +107/03/24, 06:03 -
core-ci voted on patch set 3 V +1 07/03/24, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60891
-
Christian Kuhn commented on patch set 3 CR +1 V +1 09/19/24, 22:27
Reply
Done -
Stefan Bürk voted on patch set 3 CR +2 V +2 09/20/24, 09:49
-
Stefan Bürk merged patch set 4 09/20/24, 09:58