Review 12.4 Merged

84963[BUGFIX] Fix image manipulation GUI only operating on 1st crop variant

Jasmina Ließmann CR +2 V +2 Easy +13 −7 updated 07/01/24, 20:13

Commit message

When multiple crop variants are defined (for example in EXT:styleguide
"Form engine elements - imageManipulation" for "crop_5" with
"mobile" and "desktop), the currently selected aspect ratio
and the size of the cropping box was only computed based on the
first crop variant.

This patch uses a wrapping container for each variant and adjusts
the JavaScript to operate on that context.

The information for the current cropping box size is now also
based on this context.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Jasmina Ließmann commented on patch set 1 07/01/24, 19:48

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/01/24, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60792

  3. Jasmina Ließmann voted on patch set 1 CR +2 V +2 07/01/24, 20:13

  4. Jasmina Ließmann merged patch set 2 07/01/24, 20:13