Review main Merged

84994[TASK] Avoid invalid object type in FileExtensionFilter

Christian Kuhn CR +2 V +2 Easy +2 −4 updated 06/28/24, 14:15

Commit message

filter() retrieves 'DataHandler|DatabaseRecordList $dataHandler'
as argument to call $dataHandler->deleteAction on it.
DatabaseRecordList and extending classes have no such method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 06/28/24, 13:03

  2. core-ci voted on patch set 1 V +1 06/28/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60562

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 06/28/24, 13:18

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 06/28/24, 13:40

  5. Oliver Klee voted on patch set 1 CR +1 06/28/24, 14:00

  6. Christian Kuhn voted on patch set 1 CR +2 V +2 06/28/24, 14:15

  7. Christian Kuhn merged patch set 2 06/28/24, 14:15