85033[TASK] Port exception code integrity checker into php integrity task
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 7
- Build/gitlab-ci/nightly/integrity.yml+0 −1
- Build/gitlab-ci/pre-merge/integrity.yml+0 −1
- Build/Scripts/phpIntegrityChecks/NodeResolver/ExceptionConstructorResolver.phpnew+47 −0
- Build/Scripts/phpIntegrityChecks/ExceptionCodeChecker.php2new+132 −0
- Build/Scripts/phpIntegrityChecker.php+28 −7
- Build/Scripts/runTests.sh+0 −5
- typo3/sysext/core/Classes/Compatibility/PublicMethodDeprecationTrait.php+2 −2
Review log 3552
Show 1727 earlier messages
-
Anja Leichsenring uploaded patch set 1 06/30/24, 13:54
-
Anja Leichsenring commented on patch set 1 06/30/24, 13:55
I am fine with removing the Fixture after testing here, but I think I would not hurt to keep it, together with the commented out integration into the check. -
Anja Leichsenring commented on patch set 1 06/30/24, 13:57
the original check script provides a list of all exception codes in the codebase. This function has not yet been ported, that is also why the original file has not been removed. I want to come up with a more intelligent approach to that use case and provide a stand alone call for the list, so consumers don't need to bother with the whole integrity check in tow. This will happen in a follow up patch. -
core-ci voted on patch set 1 V -1 06/30/24, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60685
-
Anja Leichsenring uploaded patch set 2
V -106/30/24, 14:08 -
core-ci voted on patch set 2 V +1 06/30/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60690
-
Stefan Bürk uploaded patch set 3
V +106/30/24, 14:41 -
core-ci voted on patch set 3 V +1 06/30/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60697
-
Stefan Bürk commented on patch set 4
V +106/30/24, 14:52Published edit on patch set 3. -
Stefan Bürk commented on patch set 5 06/30/24, 14:55
Published edit on patch set 4. -
Stefan Bürk commented on patch set 5 CR -1 06/30/24, 14:59
on it ...ExceptionCodeChecker.php:32Is this not superflous ? composer autoloader should already be included within `Build/Scripts/phpIntegrityChecker.php` - or do I miss something ? -
core-ci voted on patch set 4 V +1 06/30/24, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60698
-
core-ci voted on patch set 5 V -1 06/30/24, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60699
-
Stefan Bürk uploaded patch set 6
CR -1V -106/30/24, 15:26 -
Stefan Bürk uploaded patch set 7 06/30/24, 15:30
-
core-ci voted on patch set 6 V -1 06/30/24, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60700
-
core-ci voted on patch set 7 V +1 06/30/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60701
-
Stefan Bürk commented on patch set 7 06/30/24, 15:48
ExceptionCodeChecker.php:32ReplyDone -
Anja Leichsenring uploaded patch set 8
V +107/01/24, 06:20 -
core-ci voted on patch set 8 V +1 07/01/24, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60726
-
Anja Leichsenring marked it work in progress 07/02/24, 13:24
-
Anja Leichsenring uploaded patch set 9
V +107/05/24, 08:04 -
Anja Leichsenring commented on patch set 9 07/05/24, 08:05
relies on the workaround / code addition to nikic/PHP-Parser described here: https://github.com/nikic/PHP-Parser/issues/1011 -
core-ci voted on patch set 9 V -1 07/05/24, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61022
-
Anja Leichsenring uploaded patch set 10
V -107/05/24, 08:59 -
core-ci voted on patch set 10 V -1 07/05/24, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61025
-
Anja Leichsenring uploaded patch set 11
V -107/05/24, 09:09
-
Anja Leichsenring uploaded patch set 12 07/05/24, 09:11
-
core-ci voted on patch set 12 V -1 07/05/24, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61028
-
core-ci voted on patch set 11 V -1 07/05/24, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61027
-
Anja Leichsenring uploaded patch set 13
V -107/05/24, 09:40 -
core-ci voted on patch set 13 V +1 07/05/24, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61035
-
Anja Leichsenring marked it ready for review 07/05/24, 09:46
-
Anja Leichsenring commented on patch set 13 07/05/24, 09:46
ready for review now. -
Oliver Klee commented on patch set 13 07/05/24, 10:04
Should this really be "respect", or should it be "detect" instead? -
Anja Leichsenring wrote 07/05/24, 11:21
Set private -
Anja Leichsenring marked it work in progress 07/05/24, 11:21
-
Anja Leichsenring wrote 07/05/24, 11:43
Unset private -
Anja Leichsenring uploaded patch set 14
V +107/06/24, 08:42 -
Anja Leichsenring marked it ready for review 07/06/24, 08:44
-
Anja Leichsenring uploaded patch set 15 07/06/24, 08:47
-
core-ci voted on patch set 14 V +1 07/06/24, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61088
-
Anja Leichsenring uploaded patch set 16 07/06/24, 08:50
-
core-ci voted on patch set 15 V -1 07/06/24, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61089
-
core-ci voted on patch set 16 V +1 07/06/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61090
-
Stefan Bürk commented on patch set 16 07/06/24, 19:30
Reply
Done -
Christian Kuhn uploaded patch set 17
V +107/09/24, 07:28 -
Christian Kuhn commented on patch set 16 07/09/24, 07:28
Reply
Done -
core-ci voted on patch set 17 V +1 07/09/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61213
-
Christian Kuhn voted on patch set 17 CR +1 V +1 07/09/24, 07:35
-
Stefan Bürk voted on patch set 17 CR +2 V +2 07/09/24, 10:49
-
Stefan Bürk merged patch set 18 07/09/24, 10:49