Review main Merged

85033[TASK] Port exception code integrity checker into php integrity task

Anja Leichsenring CR +2 V +2 Normal +209 −16 updated 07/09/24, 10:49

Commit message

Port the duplicate exception code integrity check into the PhpParser
based integrity suite.

This allows for improvements compared with the older regex based
search, that missed quite some occurences.

We can now detect non-standard parameter position, named arguments
and also missing exception codes.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 3552

Show 1727 earlier messages
  1. Anja Leichsenring uploaded patch set 1 06/30/24, 13:54

  2. Anja Leichsenring commented on patch set 1 06/30/24, 13:55

    I am fine with removing the Fixture after testing here, but I think I would not hurt to keep it, together with the commented out integration into the check.
  3. Anja Leichsenring commented on patch set 1 06/30/24, 13:57

    the original check script provides a list of all exception codes in the codebase. This function has not yet been ported, that is also why the original file has not been removed. I want to come up with a more intelligent approach to that use case and provide a stand alone call for the list, so consumers don't need to bother with the whole integrity check in tow. This will happen in a follow up patch.
  4. core-ci voted on patch set 1 V -1 06/30/24, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60685

  5. Anja Leichsenring uploaded patch set 2 V -1 06/30/24, 14:08

  6. core-ci voted on patch set 2 V +1 06/30/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60690

  7. Stefan Bürk uploaded patch set 3 V +1 06/30/24, 14:41

  8. core-ci voted on patch set 3 V +1 06/30/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60697

  9. Stefan Bürk commented on patch set 4 V +1 06/30/24, 14:52

    Published edit on patch set 3.
  10. Stefan Bürk commented on patch set 5 06/30/24, 14:55

    Published edit on patch set 4.
  11. Stefan Bürk commented on patch set 5 CR -1 06/30/24, 14:59

    on it ...

    ExceptionCodeChecker.php:32

    Is this not superflous ? composer autoloader should already be included within `Build/Scripts/phpIntegrityChecker.php` - or do I miss something ?
  12. core-ci voted on patch set 4 V +1 06/30/24, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60698

  13. core-ci voted on patch set 5 V -1 06/30/24, 15:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60699

  14. Stefan Bürk uploaded patch set 6 CR -1 V -1 06/30/24, 15:26

  15. Stefan Bürk uploaded patch set 7 06/30/24, 15:30

  16. core-ci voted on patch set 6 V -1 06/30/24, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60700

  17. core-ci voted on patch set 7 V +1 06/30/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60701

  18. Stefan Bürk commented on patch set 7 06/30/24, 15:48

    ExceptionCodeChecker.php:32 Reply

    Done
  19. Anja Leichsenring uploaded patch set 8 V +1 07/01/24, 06:20

  20. core-ci voted on patch set 8 V +1 07/01/24, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60726

  21. Anja Leichsenring marked it work in progress 07/02/24, 13:24

  22. Anja Leichsenring uploaded patch set 9 V +1 07/05/24, 08:04

  23. Anja Leichsenring commented on patch set 9 07/05/24, 08:05

    relies on the workaround / code addition to nikic/PHP-Parser described here: https://github.com/nikic/PHP-Parser/issues/1011
  24. core-ci voted on patch set 9 V -1 07/05/24, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61022

  25. Anja Leichsenring uploaded patch set 10 V -1 07/05/24, 08:59

  26. core-ci voted on patch set 10 V -1 07/05/24, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61025

  27. Anja Leichsenring uploaded patch set 11 V -1 07/05/24, 09:09

  1. Anja Leichsenring uploaded patch set 12 07/05/24, 09:11

  2. core-ci voted on patch set 12 V -1 07/05/24, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61028

  3. core-ci voted on patch set 11 V -1 07/05/24, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61027

  4. Anja Leichsenring uploaded patch set 13 V -1 07/05/24, 09:40

  5. core-ci voted on patch set 13 V +1 07/05/24, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61035

  6. Anja Leichsenring marked it ready for review 07/05/24, 09:46

  7. Anja Leichsenring commented on patch set 13 07/05/24, 09:46

    ready for review now.
  8. Oliver Klee commented on patch set 13 07/05/24, 10:04

    Should this really be "respect", or should it be "detect" instead?
  9. Anja Leichsenring wrote 07/05/24, 11:21

    Set private
  10. Anja Leichsenring marked it work in progress 07/05/24, 11:21

  11. Anja Leichsenring wrote 07/05/24, 11:43

    Unset private
  12. Anja Leichsenring uploaded patch set 14 V +1 07/06/24, 08:42

  13. Anja Leichsenring marked it ready for review 07/06/24, 08:44

  14. Anja Leichsenring uploaded patch set 15 07/06/24, 08:47

  15. core-ci voted on patch set 14 V +1 07/06/24, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61088

  16. Anja Leichsenring uploaded patch set 16 07/06/24, 08:50

  17. core-ci voted on patch set 15 V -1 07/06/24, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61089

  18. core-ci voted on patch set 16 V +1 07/06/24, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61090

  19. Stefan Bürk commented on patch set 16 07/06/24, 19:30

    Reply

    Done
  20. Christian Kuhn uploaded patch set 17 V +1 07/09/24, 07:28

  21. Christian Kuhn commented on patch set 16 07/09/24, 07:28

    Reply

    Done
  22. core-ci voted on patch set 17 V +1 07/09/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61213

  23. Christian Kuhn voted on patch set 17 CR +1 V +1 07/09/24, 07:35

  24. Stefan Bürk voted on patch set 17 CR +2 V +2 07/09/24, 10:49

  25. Stefan Bürk merged patch set 18 07/09/24, 10:49