Review main Merged

85034[TASK] Fix CGL issues

Stefan Bürk CR +2 V +2 Easy +43 −5 updated 07/01/24, 06:04

Commit message

Apply the latest rules of php-cs-fixer for
both fixer (code and header-comment) also
in the `Build/Scripts` folder.

The Build folder is now added to the usual
php-cs-fixer execution for code and header
fixer scripts to avoid code style drifitng
in this folder for the future.

Used command(s):

  Build/Scripts/runTests.sh -s cgl ; \
    Build/Scripts/runTests.sh -s cglHeader

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 811

  1. Stefan Bürk uploaded patch set 1 06/30/24, 14:04

  2. Stefan Bürk updated the commit message in patch set 2 06/30/24, 14:10

  3. core-ci voted on patch set 1 V +1 06/30/24, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60686

  4. core-ci voted on patch set 2 V +1 06/30/24, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60691

  5. Stefan Bürk rebased onto patch set 3 V +1 06/30/24, 14:41

  6. core-ci voted on patch set 3 V +1 06/30/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60696

  7. Oliver Klee voted on patch set 3 CR +1 V +1 06/30/24, 15:20

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 07/01/24, 05:26

  9. Georg Ringer voted on patch set 3 CR +1 V +1 07/01/24, 05:51

  10. Stefan Bürk voted on patch set 3 CR +2 V +2 07/01/24, 06:04

  11. Stefan Bürk merged patch set 4 07/01/24, 06:04