Review main Merged

85039[TASK] Make codemirror respect color-scheme

Benjamin Kott CR +2 V +2 Easy +17 −18 updated 07/01/24, 08:49

Commit message

We are adapting the CodeMirror implementation to also
respect the current `color-scheme`, instead of purly rely on
`prefers-color-scheme`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benjamin Kott uploaded patch set 1 07/01/24, 07:30

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 07/01/24, 07:33

  3. core-ci voted on patch set 1 V +1 07/01/24, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60728

  4. Oli Bartsch voted on patch set 1 CR +2 V +2 07/01/24, 08:49

  5. Oli Bartsch merged patch set 2 07/01/24, 08:49