Review main Merged

85094[TASK] Add examples for TCA `file` in FlexForms

Oli Bartsch CR +2 V +2 Normal +67 −3 updated 07/03/24, 17:40

Commit message

This adds new fields to EXT:styleguide for
testing TCA type `file` in FlexForm.

Additionally, this also properly tests
that TcaPreparation is working for `file`
in FlexForm context. This includes the
`columnsOverrides` and `overrideChildTca`
functionality as well as the special
allowed / disallowed evaluation and
corresponding placeholder replacement.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 07/03/24, 13:17

  2. core-ci voted on patch set 1 V +1 07/03/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60908

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 07/03/24, 14:47

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 07/03/24, 16:57

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 07/03/24, 17:40

  6. Oli Bartsch merged patch set 2 07/03/24, 17:40