Review main Merged

85158[BUGFIX] Add missing sortable folder timestamps to filelist view

Garvin Hicking CR +2 V +2 Easy +20 −2 updated 07/10/24, 07:59

Commit message

With the introduction of the new filelist functionality,
the list view of folders no longer showed their last modification
timestamps. Without this information, the list view could no
longer sort the whole item list by date.

With this patch, the information is now fetched not only for
files, but also for folders.

Folders and files are sorted on their own, so no file will be
sorted in between a list of folders (and vice versa).

(Note that for filesystem folders there is only one timestamp,
so "last modified" and "created at" will use the same timestamps.
Remote folders with their distinct drivers may provide distinguishable
information.)

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Riccardo De Contardi +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Garvin Hicking uploaded patch set 1 07/08/24, 20:23

  2. core-ci voted on patch set 1 V -1 07/08/24, 20:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61188

  3. Garvin Hicking uploaded patch set 2 V -1 07/08/24, 20:29

    Remove nullable
  4. core-ci voted on patch set 2 V +1 07/08/24, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61189

  5. Riccardo De Contardi commented on patch set 1 V -1 07/08/24, 20:39

    After applying the patch the creation date is visible under the "Creation date" column also for folders; but... as far as I can see if I click on the column header the folders looks still ordered by name (ascending / descending) while the files are correctly ordered by date (ascending / descending)
  6. Garvin Hicking commented on patch set 2 07/08/24, 20:57

    Reply

    Can you attach a screenshot to the issue? It worked for me, I'll attach mine.
  7. Garvin Hicking commented on patch set 2 07/08/24, 21:01

    Reply

    Oh, I'm seeing it now. Guess I was too tired and didn't see the sorting was off. Probably the controller is applying some magic to distinguish sorting on files and folders. Will have another look.
  8. Garvin Hicking uploaded patch set 3 V +1 07/08/24, 21:08

    Actually sort this thing out
  9. Garvin Hicking commented on patch set 3 07/08/24, 21:10

    Reply

    Please try again. 😊 It is a bit odd, if you sort by reverse, the files will get put on top of the folders. So if you would expect the latest folder on top of the list, you'll first see all files sorted by date (latest on top) and then the folders (latest on top). Or the other way round: Oldest folder on top, then after the folder listing, oldest file on top. I am quite sure this is intentional, even though it "feels weird", I think it does have merrit to do it like this.
  10. core-ci voted on patch set 3 V +1 07/08/24, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61190

  11. Riccardo De Contardi commented on patch set 3 07/08/24, 21:25

    Reply

    It looks like that it mimics Windows' File Explorer behavior but I don't know either if it is intentional ;) Orthodox file managers (like FreeCommander on Windows or Pathfinder on Mac) usually always keep first folders and then files
  12. Riccardo De Contardi commented on patch set 3 V +1 07/08/24, 21:25

    Latest patch works better - see also previous comment
  13. Garvin Hicking commented on patch set 3 07/08/24, 21:36

    Reply

    Thanks for checking again! I'd say for this scope we leave the sorting as-is, and if we always want folders first and then files, we can do it with a separate patch.
  14. Georg Ringer voted on patch set 3 CR +1 V +1 07/09/24, 04:42

  15. Oli Bartsch voted on patch set 3 CR +2 V +2 07/10/24, 07:59

  16. Oli Bartsch merged patch set 4 07/10/24, 07:59