Review main Abandoned

85181[WIP][BUGFIX] Allow to share links to secondary backend module routes

Benjamin Franzke CR 0 V 0 Easy +5 −4 updated 08/27/24, 07:32

Commit message

Applies to links for module/site/settings/edit?site=site_configuration
which is encoded as `redirect=site_configuration.edit`.

The identifier `site_configuration.edit` needs to be treated as
module-route, but is currently treated as module-identifier.

TODO:
 * Add some generic method to ModuleRegistry(?) to load a module
   from a route-identifier, instead of parsing magically.
 * Need to add routeOptions.redirect for allowed parameters?
   * Currently works without :\

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 59

  1. Benjamin Franzke uploaded patch set 1 07/09/24, 13:18

  2. core-ci voted on patch set 1 V +1 07/09/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61237

  3. Benjamin Franzke rebased onto patch set 2 V +1 08/08/24, 09:07

  4. core-ci voted on patch set 2 V +1 08/08/24, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63033

  5. Benjamin Franzke rebased onto patch set 3 V +1 08/16/24, 08:52

  6. core-ci voted on patch set 3 V +1 08/16/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63564

  7. Benjamin Franzke rebased onto patch set 4 V +1 08/19/24, 13:25

  8. core-ci voted on patch set 4 V -1 08/19/24, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63774

  9. Benjamin Franzke abandoned the change 08/27/24, 07:32