Review main Merged

85182[TASK] Use explicit flatpickr types

Andreas Kienast CR +2 V +2 Easy +9 −14 updated 07/09/24, 16:22

Commit message

The date time picker module `@typo3/backend/date-time-picker` uses
flatpickr, but wasn't aware of it due loose `any` usages. The code is
modified to make use of the typings shipped with flatpickr.

To solve this long-standing issue, the module identifier is changed from
`flatpickr/flatpickr.min` to `flatpickr`, which requires an additional
entry in the `JavaScriptModules.php` configuration, but allows to remove
a module declaration.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 910

  1. Andreas Kienast uploaded patch set 1 07/09/24, 13:46

  2. Mathias Brodala commented on patch set 1 07/09/24, 13:49

    index.d.ts:123

    This line can/should be updated by now?
  3. core-ci voted on patch set 1 V +1 07/09/24, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61239

  4. Andreas Kienast commented on patch set 1 07/09/24, 13:54

    index.d.ts:123 Reply

    No, there is still flatpickr-related stuff left.
  5. Benni Mack voted on patch set 1 CR +1 V +1 07/09/24, 14:40

  6. Christian Kuhn voted on patch set 1 CR +1 V +1 07/09/24, 15:37

  7. Garvin Hicking commented on patch set 1 CR +1 V +1 07/09/24, 16:10

    Still properly works for me in Firefox and Chromium OSX in various Styleguide scenarios
  8. Andreas Kienast voted on patch set 1 CR +2 V +2 07/09/24, 16:22

  9. Andreas Kienast merged patch set 2 07/09/24, 16:22

  10. Andreas Kienast commented on patch set 2 07/09/24, 16:22

    will do the backports later