Review 12.4 Merged

85188[TASK] Use explicit flatpickr types

Andreas Kienast CR +2 V +2 Easy +9 −14 updated 07/09/24, 19:49

Commit message

The date time picker module `@typo3/backend/date-time-picker` uses
flatpickr, but wasn't aware of it due loose `any` usages. The code is
modified to make use of the typings shipped with flatpickr.

To solve this long-standing issue, the module identifier is changed from
`flatpickr/flatpickr.min` to `flatpickr`, which requires an additional
entry in the `JavaScriptModules.php` configuration, but allows to remove
a module declaration.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Andreas Kienast uploaded patch set 1 07/09/24, 19:28

  2. core-ci voted on patch set 1 V +1 07/09/24, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61254

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 07/09/24, 19:49

  4. Andreas Kienast merged patch set 2 07/09/24, 19:49