Review 12.4 Merged

85192[BUGFIX] Provide luxon-compatible format token for aria labels in flatpickr

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 07/10/24, 07:21

Commit message

The flatpickr integration in TYPO3 is configured to use luxon for date
time formatting operations, which consumes different format tokens. This
leads to the situation that aria labels generated by flatpickr are now
broken.

This commit changes the option `ariaDateFormat` to luxon's `DDDD` token,
which renders a "localized date with full month and weekday", according
to [1].

[1] https://moment.github.io/luxon/#/formatting?id=table-of-tokens

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 07/10/24, 07:12

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 07/10/24, 07:14

  3. core-ci voted on patch set 1 V +1 07/10/24, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61287

  4. Benjamin Franzke merged patch set 2 07/10/24, 07:21