Review main Merged

85255[FEATURE] Allow setting opacity in TCA type=color element

Georg Ringer CR +2 V +2 Normal +61 −11 updated 07/12/24, 20:50

Commit message

If the TCA setting `opacity` of a color element is set to true,
an editor can now select a color and its opacity using the color
notation RRGGBBAA.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 710

  1. Georg Ringer uploaded patch set 1 07/12/24, 19:42

  2. Georg Ringer commented on patch set 1 07/12/24, 19:42

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 07/12/24, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61509

  4. Benni Mack commented on patch set 2 V +1 07/12/24, 19:59

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V -1 07/12/24, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61510

  6. Garvin Hicking uploaded patch set 3 V -1 07/12/24, 20:34

    Adjust RST inline comment and field size
  7. Garvin Hicking commented on patch set 3 CR +1 V +1 07/12/24, 20:35

    Nice; works for me (don't know much about edge cases though)
  8. core-ci voted on patch set 3 V +1 07/12/24, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61511

  9. Benni Mack voted on patch set 3 CR +2 V +2 07/12/24, 20:50

  10. Benni Mack merged patch set 4 07/12/24, 20:50