85286[TASK] Prepare selectSingle fields to use maxitems=1
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 24
- typo3/sysext/backend/Configuration/SiteConfiguration/site_language.php+0 −1
- typo3/sysext/core/Classes/Configuration/Tca/TcaPreparation.php+25 −1
- typo3/sysext/core/Configuration/TCA/pages.php+0 −2
- typo3/sysext/core/Configuration/TCA/sys_file.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_file_metadata.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline/Configuration/TCA/tx_testirremnattributeinline_hotel_offer_rel.php+0 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple/Configuration/TCA/tx_testirremnattributesimple_hotel_offer_rel.php+0 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_mnsymmetric/Configuration/TCA/tx_testirremnsymmetric_hotel_rel.php+0 −2
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaPreparationTest.php+7 −0
- typo3/sysext/extbase/Configuration/TCA/Overrides/fe_users.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TCA/tx_parentchildtranslation_domain_model_main.php+0 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/parent_child_translation/Configuration/TCA/tx_parentchildtranslation_domain_model_squeeze.php+0 −2
- typo3/sysext/filemetadata/Configuration/TCA/Overrides/sys_file_metadata.php+0 −1
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −1
- typo3/sysext/indexed_search/Configuration/TCA/index_config.php+0 −4
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_displaycond.php+0 −8
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_mnsymmetric_mm.php+0 −2
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_mn_mm.php+0 −2
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationbox_mm.php+0 −4
Show 4 more files
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombinationgroup_mm.php+0 −2
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_usecombination_mm.php+0 −4
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_required.php+1 −2
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_typeforeign.php+0 −2
Review log 1013
-
Oli Bartsch uploaded patch set 1 07/18/24, 15:45
-
core-ci voted on patch set 1 V -1 07/18/24, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61750
-
Oli Bartsch uploaded patch set 2
V -107/18/24, 16:05 -
core-ci voted on patch set 2 V +1 07/18/24, 16:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61752
-
Benni Mack voted on patch set 2 CR +1 V +1 07/18/24, 17:29
-
Nikita Hovratov commented on patch set 2 07/19/24, 09:26
Nice, this resolves one point in a discussion we had here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69906/8 Should we then also remove all maxitems => 1 configs within this patch, or do you want a separate patch for this? -
Oli Bartsch uploaded patch set 3
CR +1V +107/19/24, 11:35 -
core-ci voted on patch set 3 V +1 07/19/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61809
-
Oli Bartsch commented on patch set 3 07/19/24, 11:49
Reply
Done -
Benni Mack voted on patch set 3 CR +1 V +1 07/19/24, 11:50
-
Georg Ringer voted on patch set 3 CR +2 V +2 07/19/24, 11:51
-
Georg Ringer merged patch set 4 07/19/24, 11:51
-
Nikita Hovratov commented on patch set 4 07/20/24, 15:49
Reply
Thanks!