Review main Merged

85290[DOCS] Properly refer to "loadJavaScriptModule" in Changelog

Garvin Hicking CR +2 V +2 Easy +6 −5 updated 07/19/24, 06:12

Commit message

The Changelog mistakenly referred to
"PageRenderer::loadJavaScriptModules"
(even though the example code itself was right).

To avoid confusion of the method not being static, the notation is
also changed from "::" to "->" to indicate a non-static class member
method.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Garvin Hicking uploaded patch set 1 07/18/24, 21:42

  2. core-ci voted on patch set 1 V +1 07/18/24, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61763

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 07/19/24, 04:29

  4. Georg Ringer voted on patch set 1 CR +2 V +2 07/19/24, 06:12

  5. Georg Ringer merged patch set 2 07/19/24, 06:12