Review main Merged

85304[TASK] Use standard attributes in EXT:felogin

Stephan Großberndt CR +2 V +2 Easy +6 −6 updated 07/19/24, 22:02

Commit message

With Fluid v2.12.0 using `additionalAttributes` became obsolete in
`TagBasedViewhelper` (see https://github.com/TYPO3/Fluid/pull/859).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Stephan Großberndt uploaded patch set 1 07/19/24, 11:59

  2. core-ci voted on patch set 1 V +1 07/19/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61815

  3. Christian Kuhn commented on patch set 1 CR +1 V +1 07/19/24, 13:01

    ShowChangePassword.html:20

    note this is a side-change: if no value is set, this fails server-side already.
  4. Stefan Bürk voted on patch set 1 CR +1 V +1 07/19/24, 13:07

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 07/19/24, 13:10

  6. Christian Kuhn merged patch set 2 07/19/24, 13:10

  7. Christian Kuhn commented on patch set 2 07/19/24, 19:56

    Login.html:32

    foo. this should be 'required="required"', same at other places. we'll have another patch to fix this again.
  8. Christian Kuhn commented on patch set 2 07/19/24, 21:43

  9. Stephan Großberndt commented on patch set 2 07/19/24, 22:02

    Login.html:32 Reply

    `required="true"` is correct here as "required" is registered as bool in f:form.textfield. the place to fix in https://review.typo3.org/c/Packages/TYPO3.CMS/+/85311 is in the usage below in f:form.password