Review main Merged

85311[BUGFIX] Correct attribute "required" in felogin

Stephan Großberndt CR +2 V +2 Easy +3 −3 updated 07/20/24, 07:17

Commit message

The usages of `PasswordViewHelper` now render
`required="required"` instead of `required="true"`.

ViewHelpers that do not register "required" as an argument
(e.g. `PasswordViewHelper`) pass any value since
Fluid v2.12.0 (see https://github.com/TYPO3/Fluid/pull/859).

ViewHelpers that register "required" as an argument
(e.g. `TextfieldViewHelper`) interpret the specified value
as a bool and if true always render `required="required"`
and omit the attribute if false.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Stephan Großberndt uploaded patch set 1 07/19/24, 21:27

  2. Christian Kuhn voted on patch set 1 CR +1 V +1 07/19/24, 21:31

  3. core-ci voted on patch set 1 V +1 07/19/24, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/61843

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 07/20/24, 07:16

  5. Stefan Bürk merged patch set 2 07/20/24, 07:17