Review main Merged

85404[BUGFIX] Provide null coalesce operator for array_pop

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 07/29/24, 13:43

Commit message

In the RestoreRegisterContentObject::render method a call
to array_pop is performed. The result is assigned to the
variable $frontendController->register which has type array.
However array_pop can return null, this patch add's a
null coalesce operator to ensure that correct type.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Thomas Hohn uploaded patch set 1 07/29/24, 10:59

  2. core-ci voted on patch set 1 V +1 07/29/24, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62367

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 07/29/24, 12:51

  4. Benni Mack voted on patch set 1 CR +2 V +2 07/29/24, 13:43

  5. Benni Mack merged patch set 2 07/29/24, 13:43