Review main Merged

85427[TASK] Split extension category logic from model into dedicated enum

Nikita Hovratov CR +2 V +2 Normal +70 −125 updated 08/02/24, 10:24

Commit message

This is the first step to free the extension table from TCA.
First, the Model has to be slimmed out by extracting the logic
into dedicated services. Starting with categories, a new enum
for the string and integer representation have been created
with a custom `fromValue(int|string)` method returning category
Miscellaneous as default (fallback) enum.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1218

  1. Nikita Hovratov uploaded patch set 1 07/31/24, 12:25

  2. core-ci voted on patch set 1 V +1 07/31/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62541

  3. Georg Ringer voted on patch set 1 CR +1 V +1 08/01/24, 18:22

  4. Stefan Bürk voted on patch set 1 CR -1 08/01/24, 19:02

  5. Stefan Bürk uploaded patch set 2 CR +1 V +1 08/01/24, 20:26

  6. Stefan Bürk voted on patch set 2 CR -1 08/01/24, 20:29

  7. core-ci voted on patch set 2 V -1 08/01/24, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62645

  8. core-ci voted on patch set 2 V +1 08/01/24, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62645

  9. Stefan Bürk uploaded patch set 3 CR -1 V +1 08/01/24, 22:27

  10. core-ci voted on patch set 3 V +1 08/01/24, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62689

  11. Stefan Bürk updated the commit message in patch set 4 V +1 08/01/24, 22:39

  12. Stefan Bürk uploaded patch set 5 08/01/24, 22:41

  13. core-ci voted on patch set 5 V +1 08/01/24, 22:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62692

  14. core-ci voted on patch set 4 V +1 08/01/24, 22:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62691

  15. Georg Ringer voted on patch set 5 CR +1 V +1 08/02/24, 07:00

  16. Stefan Bürk voted on patch set 5 CR +1 V +1 08/02/24, 08:25

  17. Nikita Hovratov voted on patch set 5 CR +2 V +2 08/02/24, 10:24

  18. Nikita Hovratov merged patch set 6 08/02/24, 10:24