Review main Merged

85479[BUGFIX] Use localization parent for translated site root preview

Friedemann Altrock CR +2 V +2 Easy +25 −1 updated 04/01/25, 20:09

Commit message

In the edit view of a page, the page UID itself is used as the target
page for the preview button. This does not work for translated site
roots, as they cannot be mapped to a site configuration.

This uses the localization parent as the preview target if the current
page is a translated site root.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1018

  1. Friedemann Altrock uploaded patch set 1 08/01/24, 21:44

  2. core-ci voted on patch set 1 V -1 08/01/24, 21:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62678

  3. core-ci commented on patch set 1 08/01/24, 22:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62678

  4. core-ci commented on patch set 1 08/02/24, 06:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62678

  5. Friedemann Altrock uploaded patch set 2 V -1 08/02/24, 13:43

  6. core-ci voted on patch set 2 V -1 08/02/24, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62736

  7. Friedemann Altrock uploaded patch set 3 V -1 08/02/24, 14:08

  8. core-ci voted on patch set 3 V +1 08/02/24, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62739

  9. Benni Mack updated the commit message in patch set 4 V +1 10/18/24, 13:41

  10. Benni Mack rebased onto patch set 5 03/28/25, 12:10

  11. core-ci voted on patch set 5 V +1 03/28/25, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76578

  12. Benni Mack updated the commit message in patch set 6 V +1 03/28/25, 12:22

  13. core-ci voted on patch set 6 V +1 03/28/25, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76583

  14. Georg Ringer uploaded patch set 7 V +1 03/30/25, 09:11

  15. Georg Ringer commented on patch set 7 CR +1 V +1 03/30/25, 09:11

    just changed to the tcaschema
  16. core-ci voted on patch set 7 V +1 03/30/25, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76666

  17. Benni Mack voted on patch set 7 CR +2 V +2 04/01/25, 20:09

  18. Benni Mack merged patch set 8 04/01/25, 20:09