Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

85510[FEATURE] Introduce StyleAttr Fluid view helper

Oliver Hader CR 0 V 0 Normal +73 −0 updated 08/05/24, 13:52

Commit message

Example

<div style="<f:asset.styleAttr map="{
     width: '{f:if(condition: \'{dimensions.width}>0\', then: \'{dimensions.width}px\')}',
     height: '{f:if(condition: \'{dimensions.height}>0\', then: \'{dimensions.height}px\')}',
     'padding-top': '{f:if(condition: paddingTop, then: \'{paddingTop}%\')}'
}" />">

@todo: Fluid code might be better/simpler (not quote escaping)

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/85510/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/85510/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Files 1

Review log 23

  1. Oliver Hader uploaded patch set 1 08/05/24, 13:46

  2. Oliver Hader marked it work in progress 08/05/24, 13:47

  3. core-ci voted on patch set 1 V +1 08/05/24, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62853