Review main Merged

85594[DOCS] Document site sets of EXT:felogin

Lina Wolf CR +2 V +2 Hard +477 −228 updated 08/26/24, 18:16

Commit message

This patch adds a description on how to utilize
site sets from `EXT:felogin` and lists the supported
configuration directives, autogenerated from
the settings.definitions.yaml file.

Also some wording changes and typo-fixes in the
settings definitions file are applied, and fe-login
special notices are added.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 4367

Show 2842 earlier messages
  1. Lina Wolf uploaded patch set 1 08/12/24, 12:08

  2. core-ci voted on patch set 1 V +1 08/12/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63222

  3. Garvin Hicking uploaded patch set 2 V +1 08/12/24, 20:03

  4. Garvin Hicking commented on patch set 2 08/12/24, 20:06

    I see a few issues here sadly. The autogenerated YAML definition differs a bit from the existing typoscript values. And we lose all noteS/importants that were previously manually documented. Specifically: * showLogoutFormAfterLogin (note) * showForgotPassword (important) * redirectMode ("See section...") Also, in some cases like redirectFirstMethod, redirectDisable there is no default displayed (probably because 'false' or so is cast as "empty"?) There's a difference in email_from vs. emailFrom and email_fromName vs. emailFromName. Also emailLayoutRootPath vs. emailLayoutRootPaths. A setting like "pages" has been renamed to "pid" in site sets. "recursive" is listed as string, but previously was an int. As long as the typoscript+flexform settings are still around, I think we will need to display both the site set config, AND the old typoscript configuration. And we would need a note saying "pay attention some settings have been renamed in the new site set configuration files". What do you think?
  5. core-ci voted on patch set 2 V +1 08/12/24, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63259

  6. Lina Wolf uploaded patch set 3 V +1 08/16/24, 09:10

  7. Lina Wolf commented on patch set 3 08/16/24, 09:12

    Reply

    I included them again, it is true that they are still available
  8. Lina Wolf uploaded patch set 4 08/16/24, 09:15

  9. core-ci voted on patch set 3 V +1 08/16/24, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63568

  10. core-ci voted on patch set 4 V +1 08/16/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63569

  11. Stefan Bürk uploaded patch set 5 V +1 08/16/24, 09:27

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 08/16/24, 09:28

  13. Garvin Hicking commented on patch set 5 08/16/24, 09:31

    Index.rst:52

    "were" not "where"
  14. core-ci voted on patch set 5 V +1 08/16/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63570

  15. Lina Wolf commented on patch set 6 CR +1 V +1 08/16/24, 09:44

    Published edit on patch set 5.
  16. Lina Wolf commented on patch set 6 08/16/24, 09:44

    Index.rst:52 Reply

    Done
  17. Garvin Hicking commented on patch set 6 08/16/24, 09:50

    Index.rst:57

    I would like a note here like "Hint: Most of the new site set settings have the same meaning like with TypoScript setup before, but names have been changed. bear that in mind when migrating from TypoScript setup to site set settings."
  18. core-ci voted on patch set 6 V +1 08/16/24, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63573

  19. Lina Wolf uploaded patch set 7 V +1 08/16/24, 16:50

  20. Lina Wolf commented on patch set 7 08/16/24, 16:50

    Index.rst:57 Reply

    Done
  21. Lina Wolf marked it work in progress 08/16/24, 16:52

  22. Lina Wolf commented on patch set 7 08/16/24, 16:53

    Marking as work in progress. I want to first optimize the settings page in a backportable way, then do this patch on top
  23. core-ci voted on patch set 7 V +1 08/16/24, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63589

  24. Garvin Hicking commented on patch set 7 08/16/24, 19:38

    Index.rst:56

    I think there is a '<' missing?

    Index.rst:57 Reply

    thanks!:)
  25. Lina Wolf uploaded patch set 8 V +1 08/18/24, 06:24

  26. Lina Wolf marked it ready for review 08/18/24, 06:24

  27. core-ci voted on patch set 8 V +1 08/18/24, 06:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63691

  28. Lina Wolf uploaded patch set 9 V +1 08/18/24, 07:45

  29. Lina Wolf uploaded patch set 10 08/18/24, 07:47

  30. Lina Wolf commented on patch set 9 08/18/24, 07:48

    Index.rst:56 Reply

    Done
  31. core-ci voted on patch set 9 V +1 08/18/24, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63692

  32. core-ci voted on patch set 10 V +1 08/18/24, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63693

  33. Lina Wolf uploaded patch set 11 V +1 08/18/24, 07:56

  34. core-ci voted on patch set 11 V +1 08/18/24, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63694

  35. Chris Müller updated the commit message in patch set 12 V +1 08/18/24, 08:08

  36. core-ci voted on patch set 12 V +1 08/18/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63695

  37. Garvin Hicking updated the commit message in patch set 13 V +1 08/18/24, 09:01

  38. Garvin Hicking commented on patch set 13 V +1 08/18/24, 09:02

    Thanks Lina, that looks like a lot of work. I wonder if we should split the "Configuration" page in two sub-sections (seperate files). One for Site Sets, the other for "legacy" TypoScript. Because I think when someone scrolls quickly through the list, they might land in the "wrong" config section for them and they may not notice there are two different conf blocks on a single page. What do you think?
  39. core-ci voted on patch set 13 V +1 08/18/24, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63696

  40. Lina Wolf commented on patch set 13 08/18/24, 09:14

    Reply

    Sounds like a good idea, I actually considered this as well
  41. Lina Wolf uploaded patch set 14 V +1 08/18/24, 11:05

  42. core-ci voted on patch set 14 V +1 08/18/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63700

  1. Lina Wolf commented on patch set 14 08/18/24, 11:34

    Reply

    Done
  2. Lina Wolf uploaded patch set 15 V +1 08/18/24, 16:46

  3. core-ci voted on patch set 15 V -1 08/18/24, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63727

  4. core-ci voted on patch set 15 V +1 08/18/24, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63727

  5. Garvin Hicking commented on patch set 15 08/19/24, 08:58

    Index.rst:16

    If I understood Benjamin Franzkes remark in the other patch properly, there's no decision to phase out the typoscript constants here yet. I would simply remove that part for now, until this is a conscious effort?

    SiteSets.rst:1

    "Site sets"?

    TypoScript.rst:26

    This is the same as in the overview, but it's not in the "Site Sets" page where it's missing. Should we either include that section in "Site Sets" once again, too - or leave it out here for typoscript (or at least remove the 'Site set' reference there?)
  6. Sandra Erbel commented on patch set 16 V +1 08/19/24, 12:49

    Published edit on patch set 15.
  7. core-ci voted on patch set 16 V -1 08/19/24, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63768

  8. Sandra Erbel commented on patch set 17 V -1 08/19/24, 13:07

    Published edit on patch set 16.
  9. Sandra Erbel commented on patch set 18 08/19/24, 13:10

    Published edit on patch set 17.
  10. core-ci voted on patch set 17 V +1 08/19/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63771

  11. core-ci voted on patch set 18 V +1 08/19/24, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63772

  12. core-ci voted on patch set 16 V +1 08/19/24, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63768

  13. Lina Wolf uploaded patch set 19 V +1 08/26/24, 09:58

  14. Lina Wolf commented on patch set 19 08/26/24, 09:59

    Index.rst:16 Reply

    Removed the phasing out

    SiteSets.rst:1 Reply

    Done

    TypoScript.rst:26 Reply

    Made an include and include it in all 3 places. It cannot harm to place this into several places.
  15. core-ci voted on patch set 19 V +1 08/26/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64191

  16. Garvin Hicking commented on patch set 19 CR +1 V +1 08/26/24, 15:56

    Nice, this looks good to me.
  17. Chris Müller uploaded patch set 20 CR +1 V +1 08/26/24, 16:28

  18. core-ci voted on patch set 20 V -1 08/26/24, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64231

  19. Chris Müller uploaded patch set 21 08/26/24, 16:41

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  20. core-ci voted on patch set 20 V +1 08/26/24, 16:44 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 21 (was Verified-1) (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64231

  21. core-ci voted on patch set 21 V +1 08/26/24, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64236

  22. Garvin Hicking voted on patch set 21 CR +1 V +1 08/26/24, 17:02

  23. Chris Müller voted on patch set 21 CR +1 V +1 08/26/24, 17:48

  24. Garvin Hicking voted on patch set 21 CR +2 V +2 08/26/24, 18:16

  25. Garvin Hicking merged patch set 22 08/26/24, 18:16