Review main Merged

85664[DOCS] Document base64 attribute of f:image

TYPO3com CR +2 V +2 Easy +26 −1 updated 08/17/24, 11:05

Commit message

references:
https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/982

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2

Issues 2

Files 1

Review log 1726

Show 01 earlier messages
  1. TYPO3com uploaded patch set 1 08/17/24, 07:42

  1. core-ci voted on patch set 1 V -1 08/17/24, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63613

  2. Lina Wolf commented on patch set 2 V -1 08/17/24, 07:55

    Published edit on patch set 1.
  3. Lina Wolf commented on patch set 3 08/17/24, 07:59

    Published edit on patch set 2.
  4. Garvin Hicking commented on patch set 2 08/17/24, 08:01

    ImageViewHelper.php:112

    are these tabs here appropriate or need be whitespace?

    ImageViewHelper.php:161

    Once base64 and once Base64, we should unify this?

    ImageViewHelper.php:161

    have you tested if emails really work with base64 encode? I think recommending this requires to make sure major mail clients all support this...?
  5. Lina Wolf commented on patch set 4 08/17/24, 08:05

    Published edit on patch set 3.
  6. Lina Wolf commented on patch set 4 08/17/24, 08:05

    ImageViewHelper.php:112 Reply

    Done

    ImageViewHelper.php:161 Reply

    This text comes from the changelog, so I suppose it has been tested
  7. core-ci voted on patch set 2 V +1 08/17/24, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63615

  8. Lina Wolf commented on patch set 5 08/17/24, 08:06

    Published edit on patch set 4.
  9. Lina Wolf commented on patch set 5 08/17/24, 08:06

    ImageViewHelper.php:161 Reply

    Done
  10. core-ci voted on patch set 3 V +1 08/17/24, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63617

  11. core-ci voted on patch set 4 V +1 08/17/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63618

  12. core-ci voted on patch set 5 V +1 08/17/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63619

  13. Garvin Hicking updated the commit message in patch set 6 V +1 08/17/24, 09:12

  14. Garvin Hicking commented on patch set 6 08/17/24, 09:16

    ImageViewHelper.php:158

    How about: If enabled, not the image's location will be used, but the contents of the file will be used, base64 encoded. Useful in FluidEmail context.
  15. Simon Praetorius commented on patch set 6 08/17/24, 09:18

    ImageViewHelper.php:158

    Suggestion: Adds the image data base64-encoded inline to the image‘s "src" attribute.
  16. core-ci voted on patch set 6 V +1 08/17/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63623

  17. Lina Wolf commented on patch set 7 V +1 08/17/24, 09:20

    Published edit on patch set 6.
  18. Lina Wolf commented on patch set 7 08/17/24, 09:21

    ImageViewHelper.php:158 Reply

    Done

    ImageViewHelper.php:158 Reply

    I applied Simons suggestion as it sounds more fluid
  19. core-ci voted on patch set 7 V +1 08/17/24, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63629

  20. Simon Praetorius voted on patch set 7 CR +1 V +1 08/17/24, 09:39

  21. Christian Kuhn voted on patch set 7 CR +1 V +1 08/17/24, 09:54

  22. Garvin Hicking updated the commit message in patch set 8 CR +1 V +1 08/17/24, 10:56

  23. Garvin Hicking voted on patch set 8 CR +2 V +2 08/17/24, 10:57

  24. Garvin Hicking merged patch set 9 08/17/24, 10:57

  25. core-ci voted on patch set 8 V +1 08/17/24, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63641