Review main Merged

85668[TASK] Sync ext:form FormPersistenceManagerInterface

Christian Kuhn CR +2 V +2 Hard +113 −161 updated 08/17/24, 10:22

Commit message

To prepare further works on the implementing class,
FormPersistenceManagerInterface is synchronized with
some methods FormPersistenceManager implements and
are needed, but are not within the interface, yet.

Method checkForDuplicateIdentifier() is used internally
only, and removed from the interface.

Move public methods to top in FormPersistenceManager,
remove an obsolete attribute of the "fake request"
(which will see more handling with another patch), and
mark the implementing class @internal since everything
can be programmed to the interface.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Christian Kuhn uploaded patch set 1 08/17/24, 09:16

  2. core-ci voted on patch set 1 V -1 08/17/24, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63626

  3. Christian Kuhn uploaded patch set 2 V -1 08/17/24, 09:50

  4. core-ci voted on patch set 2 V +1 08/17/24, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63631

  5. Christian Kuhn updated the commit message in patch set 3 V +1 08/17/24, 10:10

  6. Christian Kuhn updated the commit message in patch set 4 08/17/24, 10:11

  7. Christian Kuhn updated the commit message in patch set 5 08/17/24, 10:13

  8. core-ci voted on patch set 5 V +1 08/17/24, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63635

  9. Stefan Bürk voted on patch set 5 CR +1 V +1 08/17/24, 10:21

  10. Anja Leichsenring voted on patch set 5 CR +2 V +2 08/17/24, 10:22

  11. Anja Leichsenring merged patch set 6 08/17/24, 10:22