85669[TASK] Do not use ConfigurationManager in FormPersistenceManager
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 21
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+9 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php+7 −5
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+6 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php+27 −26
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+6 −1
- typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php+93 −114
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+42 −34
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+5 −11
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+170 −297
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManagerInterface.php+22 −17
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+27 −20
- typo3/sysext/form/Configuration/Services.yaml+0 −4
- typo3/sysext/form/Documentation/I/Concepts/FrontendRendering/Index.rst+3 −3
- typo3/sysext/form/Tests/Functional/Controller/FormFrontendControllerTest.php+4 −20
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+2 −2
- typo3/sysext/form/Tests/Functional/EventListener/DataStructureIdentifierListenerTest.phprenamed+119 −95
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/BlankForm.form.yamlrenamed+0 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/BlankForm.txtrenamed+0 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/Simple.form.yamlnew+13 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/FormPersistenceManagerTest.phpnew+1034 −0
Review log 2954
Show 1629 earlier messages
-
Christian Kuhn uploaded patch set 1 08/17/24, 10:53
-
core-ci voted on patch set 1 V -1 08/17/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63639
-
Christian Kuhn uploaded patch set 2
V -108/17/24, 12:47 -
Christian Kuhn uploaded patch set 3 08/17/24, 12:50
-
core-ci voted on patch set 2 V -1 08/17/24, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63655
-
core-ci voted on patch set 3 V -1 08/17/24, 12:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63656
-
Christian Kuhn uploaded patch set 4
V -108/17/24, 13:02 -
core-ci voted on patch set 4 V -1 08/17/24, 13:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63658
-
Christian Kuhn uploaded patch set 5
V -108/18/24, 09:52 -
core-ci voted on patch set 5 V -1 08/18/24, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63697
-
Christian Kuhn uploaded patch set 6
V -108/18/24, 13:27 -
core-ci voted on patch set 6 V -1 08/18/24, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63705
-
Christian Kuhn uploaded patch set 7
V -108/18/24, 13:54 -
core-ci voted on patch set 7 V -1 08/18/24, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63706
-
Christian Kuhn uploaded patch set 8
V -108/18/24, 14:03 -
core-ci voted on patch set 8 V -1 08/18/24, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63707
-
Christian Kuhn uploaded patch set 9
V -108/18/24, 14:27 -
Christian Kuhn uploaded patch set 10 08/18/24, 14:29
-
Christian Kuhn uploaded patch set 11 08/18/24, 14:35
-
core-ci voted on patch set 9 V -1 08/18/24, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63709
-
core-ci voted on patch set 10 V -1 08/18/24, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63710
-
core-ci voted on patch set 11 V -1 08/18/24, 14:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63711
-
Christian Kuhn uploaded patch set 12
V -108/18/24, 14:51 -
Christian Kuhn uploaded patch set 13 08/18/24, 14:58
-
core-ci voted on patch set 12 V -1 08/18/24, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63716
-
core-ci voted on patch set 13 V -1 08/18/24, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63718
-
Christian Kuhn uploaded patch set 14
V -108/18/24, 15:24 -
Christian Kuhn uploaded patch set 15 08/18/24, 15:27
-
Christian Kuhn uploaded patch set 16 08/18/24, 15:29
-
core-ci voted on patch set 14 V -1 08/18/24, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63721
-
core-ci voted on patch set 15 V -1 08/18/24, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63722
-
core-ci voted on patch set 16 V -1 08/18/24, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63723
-
Christian Kuhn uploaded patch set 17
V -108/19/24, 07:47 -
Christian Kuhn uploaded patch set 18 08/19/24, 07:52
-
core-ci voted on patch set 17 V -1 08/19/24, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63753
-
core-ci voted on patch set 18 V +1 08/19/24, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63754
-
Christian Kuhn uploaded patch set 19
V +108/20/24, 07:36 -
core-ci voted on patch set 19 V +1 08/20/24, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63808
-
Christian Kuhn uploaded patch set 20
V +108/20/24, 07:52 -
core-ci voted on patch set 20 V +1 08/20/24, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63809
-
Christian Kuhn updated the commit message in patch set 21
V +108/20/24, 08:07 -
core-ci voted on patch set 21 V -1 08/20/24, 08:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63810
-
core-ci voted on patch set 21 V +1 08/20/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63810
-
Christian Kuhn uploaded patch set 22
V +108/20/24, 08:32 -
Christian Kuhn uploaded patch set 23 08/20/24, 08:38
-
Christian Kuhn uploaded patch set 24 08/20/24, 08:39
-
core-ci voted on patch set 22 V +1 08/20/24, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63814
-
core-ci voted on patch set 23 V +1 08/20/24, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63816
-
core-ci voted on patch set 24 V +1 08/20/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63817
-
Stefan Bürk voted on patch set 24 CR +1 08/20/24, 08:55
-
Anja Leichsenring voted on patch set 24 CR +1 V +1 08/20/24, 08:58
-
Stefan Bürk voted on patch set 24 V +1 08/20/24, 08:59
-
Christian Kuhn voted on patch set 24 CR +2 V +2 08/20/24, 09:02
-
Christian Kuhn merged patch set 25 08/20/24, 09:02