Review main Merged

85693[BUGFIX] Explicitly set icon title in record list

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 08/20/24, 21:25

Commit message

There might be the case that the same flag
icon is used for different languages. Due
to iconFactory using a cache for generated
icons, record list needs to set the title
explicitly to prevent using a wrong title
on reusing the flag icons.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 08/20/24, 08:29

  2. core-ci voted on patch set 1 V +1 08/20/24, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63813

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 08/20/24, 10:26

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 08/20/24, 18:20

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 08/20/24, 21:25

  6. Oli Bartsch merged patch set 2 08/20/24, 21:25