Review 12.4 Merged

85704[BUGFIX] Explicitly set icon title in record list

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 08/20/24, 22:07

Commit message

There might be the case that the same flag
icon is used for different languages. Due
to iconFactory using a cache for generated
icons, record list needs to set the title
explicitly to prevent using a wrong title
on reusing the flag icons.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch uploaded patch set 1 08/20/24, 21:24

  2. core-ci voted on patch set 1 V +1 08/20/24, 21:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63859

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 08/20/24, 22:07

  4. Oli Bartsch merged patch set 2 08/20/24, 22:07