Review main Merged

85708[TASK] Use fluid attribute for Request handling

Christian Kuhn CR +2 V +2 Hard +458 −528 updated 08/21/24, 17:45

Commit message

ext:fluid RenderingContext is in the bad habit of extending
fluid standalone RenderingContext with the two methods
setRequest() and getRequest() that are not part of fluid
standalone RenderingContextInterface.

This is ugly with type hinting and can't be changed in a
good way due to liskov collisions on method signatures in
view helpers.

Fluid standalone also does not want to add these methods
itself since it - as a view - wants to avoid dependencies
to PSR-7.

Fluid standalone instead added setAttribute(), hasAttribute()
and getAttribute() to RenderingContextInterface. This allows
adding "arbitrary" objects.

The patch makes use of this: On the setter side, the
RenderingContextFactory->create() is extended to accept
the request and set it as attribute, on the has/getter side
all consumers are adapted.

This deprecates setRequest() and getRequest(), which are
changed to transparently work with the attribute instead.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1

Issues 1

Files 71

Show 51 more files

Review log 2544

Show 1119 earlier messages
  1. Christian Kuhn uploaded patch set 1 08/21/24, 10:17

  2. Christian Kuhn uploaded patch set 2 08/21/24, 10:25

  3. core-ci voted on patch set 1 V -1 08/21/24, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63894

  4. core-ci voted on patch set 2 V +1 08/21/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63895

  5. Christian Kuhn uploaded patch set 3 V +1 08/21/24, 11:11

  6. Christian Kuhn uploaded patch set 4 08/21/24, 11:18

  7. core-ci voted on patch set 3 V +1 08/21/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63899

  8. core-ci voted on patch set 4 V -1 08/21/24, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63900

  9. Christian Kuhn uploaded patch set 5 V -1 08/21/24, 11:30

  10. Christian Kuhn uploaded patch set 6 08/21/24, 11:35

  11. Christian Kuhn uploaded patch set 7 08/21/24, 11:36

  12. core-ci voted on patch set 5 V +1 08/21/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63901

  13. Christian Kuhn uploaded patch set 8 08/21/24, 11:39

  14. core-ci voted on patch set 7 V -1 08/21/24, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63903

  15. core-ci voted on patch set 8 V +1 08/21/24, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63904

  16. Christian Kuhn uploaded patch set 9 V +1 08/21/24, 12:08

  17. core-ci voted on patch set 9 V -1 08/21/24, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63905

  18. Christian Kuhn uploaded patch set 10 V -1 08/21/24, 12:38

  19. Christian Kuhn uploaded patch set 11 08/21/24, 12:45

  1. core-ci voted on patch set 10 V +1 08/21/24, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63907

  2. core-ci voted on patch set 11 V +1 08/21/24, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63910

  3. Christian Kuhn uploaded patch set 12 V +1 08/21/24, 12:54

  4. core-ci voted on patch set 12 V -1 08/21/24, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63911

  5. Christian Kuhn uploaded patch set 13 V -1 08/21/24, 16:06

  6. Christian Kuhn uploaded patch set 14 08/21/24, 16:09

  7. core-ci voted on patch set 14 V +1 08/21/24, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63920

  8. core-ci voted on patch set 13 V -1 08/21/24, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63919

  9. Christian Kuhn uploaded patch set 15 V +1 08/21/24, 16:24

  10. Christian Kuhn uploaded patch set 16 08/21/24, 16:27

  11. core-ci voted on patch set 15 V -1 08/21/24, 16:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63921

  12. core-ci voted on patch set 16 V +1 08/21/24, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63922

  13. Christian Kuhn uploaded patch set 17 V +1 08/21/24, 16:56

  14. core-ci voted on patch set 17 V +1 08/21/24, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63923

  15. Christian Kuhn updated the commit message in patch set 18 V +1 08/21/24, 17:08

  16. Christian Kuhn updated the commit message in patch set 19 08/21/24, 17:10

  17. Christian Kuhn updated the commit message in patch set 20 08/21/24, 17:10

  18. core-ci voted on patch set 18 V +1 08/21/24, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63924

  19. core-ci voted on patch set 19 V +1 08/21/24, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63925

  20. core-ci voted on patch set 20 V +1 08/21/24, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63926

  21. Christian Kuhn commented on patch set 21 V +1 08/21/24, 17:34

    Published edit on patch set 20.
  22. Anja Leichsenring voted on patch set 21 CR +1 V +1 08/21/24, 17:38

  23. Garvin Hicking voted on patch set 21 CR +1 V +1 08/21/24, 17:43

  24. Christian Kuhn voted on patch set 21 CR +2 V +2 08/21/24, 17:45

  25. Christian Kuhn merged patch set 22 08/21/24, 17:45