Review main Merged

85787[TASK] Remove ancient server side 'no cookie' detection

Christian Kuhn CR +2 V +2 Easy +0 −12 updated 08/27/24, 10:51

Commit message

There is ancient BE login related server side code to
detect if cookies can be set. This never kicks in and
is removed with the patch.

When 'setting cookies' is disallowed in a browser (see
instructions for firefox in issue), JS showCookieWarning()
detects this and enables an info box.
If JS is disabled as well, a default enabled info box
"Please enable JavaScript" is shown.

We're safe client side and can remove the server side
check that triggers a fishy reload for detection.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Simon Praetorius +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Simon Praetorius +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Christian Kuhn uploaded patch set 1 08/27/24, 10:20

  2. Christian Kuhn updated the commit message in patch set 2 08/27/24, 10:22

  3. Andreas Kienast voted on patch set 2 CR +1 V +1 08/27/24, 10:29

  4. core-ci voted on patch set 1 V -1 08/27/24, 10:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64287

  5. core-ci voted on patch set 2 V -1 08/27/24, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64288

  6. core-ci voted on patch set 2 V +1 08/27/24, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64288

  7. Simon Praetorius voted on patch set 2 CR +1 V +1 08/27/24, 10:38

  8. Jasmina Ließmann voted on patch set 2 CR +1 V +1 08/27/24, 10:39

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 08/27/24, 10:51

  10. Christian Kuhn merged patch set 3 08/27/24, 10:51