Review main Merged

85789[TASK] Avoid handling L=OUT in LoginController

Christian Kuhn CR +2 V +2 Easy +0 −6 updated 08/29/24, 09:35

Commit message

Logout should run through LogoutController.
Avoid this widely unknown code in LoginController
since it does not belong there and does not log.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 08/27/24, 11:44

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 08/27/24, 11:48

  3. core-ci voted on patch set 1 V +1 08/27/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64299

  4. Simon Praetorius voted on patch set 1 CR +1 V +1 08/27/24, 11:54

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 08/27/24, 11:56

  6. Christian Kuhn merged patch set 2 08/27/24, 11:56

  7. Markus Klein commented on patch set 2 08/27/24, 15:22

    LoginController.php:201

    You missed the comment. ;-)
  8. Christian Kuhn commented on patch set 2 08/29/24, 09:35

    LoginController.php:201 Reply